Redaction title can be blank.

[RoyallDesigns]

@1v0ryh4t and I found that when creating a new redaction under /redactions/new, the redaction title is allowed to be blank. When attempting to view said redactions under /redactions, the new redaction is not present or viewable under the list as its title or name is an empty string. I would like to add a validation to a redaction so that when creating or editing the redaction, the name can never be blank. (This seems like a decent good-first-issue for myself.)

Please see the attached images.

All redactions (/redactions):

[gravitystorm]

I think it's reasonable to require a title, should we also consider making the description required too?

I checked the original pull request for adding redactions, and I couldn't find any discussion as to whether titles and/or descriptions should be optional. I'd be interested in feedback from any openstreetmap.org moderators, who have the most experience with creating redactions. Personally I think it would be fine to require both attributes to be present.

[tomhughes]

I think it's clear a title should be required and I'd be inclined to say a description should be as well.

I'm surprised I didn't insist on it at the time - it must have slipped by me when I was reviewing this.

[rileythomp]

Does this still need to be worked on?

[SomeoneElseOSM]

I'd be interested in feedback from any openstreetmap.org moderators

Creating new redactions isn't something that we need to do that often, thankfully -the last one I did was a couple of years ago I think - https://www.openstreetmap.org/redactions/102 . I'd always expect to use a title and description.

[sonukushwaha403]

is this issue open can i work on it

[gravitystorm]

is this issue open can i work on it

Yes, the issue is open and can be worked on. Please also read through the previous pull request for more information.

[gravitystorm]

@BLSowmya Yes, the issue is open and you are welcome to work on it.

[IshmeetSingh06]

Hey @gravitystorm @tomhughes If this issue has not been picked up by anyone, I'm going to work on it, after reading the previous PR comments I want confirmation about some things:

1. We want ensure the presence of Title and Description both,
2. For missing titles and description we need fill them up with the id of the redaction?
3. In a single migration we have to backfill our data and change the column null to false right?
4. Since we are using strong migrations do we need to change null first and then Validate it inside a seperate migration as stated by the strong migration documentation?

[gravitystorm]

We want ensure the presence of Title and Description both,

Yes please

For missing titles and description we need fill them up with the id of the redaction?

I would suggest "Redaction #{id}" (i.e. the word "Redaction" followed by the id number) as the title, and "No description" as the description. But it's not super important since I don't think there are many (any?) on the osm.org servers. It might affect other deployments though.

In a single migration we have to backfill our data and change the column null to false right? Since we are using strong migrations do we need to change null first and then Validate it inside a seperate migration as stated by the strong migration documentation?

Yes, whichever approach works best with strong migrations. See https://github.com/ankane/strong_migrations?tab=readme-ov-file#setting-not-null-on-an-existing-column

Thanks for looking into this!

[IshmeetSingh06]

@gravitystorm Thanks for the clarification's I'll start working on it

[tomhughes]

Model validations were added in 873ac155cabfb1aab8d887d07bc8389617d3f843 without realising that they fixed this.