openstreetmap-website
openstreetmap-website copied to clipboard
openstreetmap
Change Windows Live to Microsoft Account
I found this request from one of the Translatewiki translators and it seems reasonable to me!
The Windows Live brand has been long discontinued. You can find a list of what Windows Live services were renamed to here.
I believe the replacement word should be 'Microsoft account'. Please update the icon on the login page and the following strings to reflect this change: user.login.auth_providers.windowslive.title and user.login.auth_providers.windowslive.alt
I'm not clear what change they are asking for where the icon is concerned? As far as I can tell other sites are using the "Microsoft Account" wording but are still using the windows flag icon like us...
We're using an old Windows logo (Vista or Windows 7 I think), whereas the Microsoft logo now includes the coloured squares without the wave effect. I would go for the coloured squares part of the Microsoft logo since that's what's shown on the following page.
Could be an issue with which I could start contributing. Is it just about replacing the icon on login page and those strings?
Well that's an interesting question...
Probably yes, despite that fact that the "windowslive" name also appears throughout the code.
The only other thing we might want to do is change the provider name, so the URLs don't have it in, but they only appear briefly and changing that will mean running a migration and also starts to make the source inconsistent unless we change it everywhere.
What do you mean with "apears through the code"? Does it mean that there are some string constants around the files that should be changed?
And about the provider name: I am new to osm and I do not have at this precise moment the ER schema to understand if provider name is a database table attribute, so I deduce that if a migration is needed it should be such
I mean that the code is littered with that text especially in the tests.
The provider name is the value with goes in the database to identify which auth provider is in use for a given user, and which appears in the auth and callback urls.
Ok all clear! I will try to solve this little issue and do a pull request. If I will need suggestions I will use this issue discussion to ask. If you everyone have others things to be taken into consideration let me know.
hi! is this issue still up for grabs? I'd like to start collaborating! Thanks!
Also stumbled across and would like to implement this. Think the logo is already updated?
So do we still want to change the repo strings [.*windowslive > .*microsoftaccount etc] and other relicts?
Further would we also change the gem
omniauth-windowslive? Following the link its github page it leads to the some deprecated microsoft app registration platform.
Would be maybe interesting to know if any users actively use windowslive sso if it still works at all with a glimpse into prod db? Else could maybe be replaced or removed?
(please forgive if I am completely wrong or misunderstanding)
I don't think it's a good idea to replace all instances of "windowslive" with "microsoft" in the code. Even though the branding for Windows Live has been discontinued by Microsoft, the omniauth-windowslive library we're using still makes sense to keep references to "windowslive". This will make it easier to replace the library if needed in the future.
Instead of updating the code, I suggest that we focus on changing the user-facing text, such as "Sign in with Windows Live" or "Login with a Windows Live Account".
I have had a look at the library we are using. Properly moving from windows live social sign-in to Microsoft account sign-in would involve moving oauth from login.live.com (old) to login.microsftonline.com (new). The ominiauth-windowslive library is basically a URL encoder for Microsoft's implementation of OAuth 2.0 on their old domain.
A probable deduction of mine is that the two domains could be interchangeable with the right encoding. However, I'm not entirely certain and could be something that could be put forward to Microsoft. @tomhughes @wtrbtl03
If true this would involve rewriting the ominiauth-windowslive for this new domain + encoding or finding another ruby library out there somewhere.
Sources:
old: https://web.archive.org/web/20170711195343/http://msdn.microsoft.com/en-us/library/hh243647.aspx
new: https://learn.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-auth-code-flow
I wouldn't worry about it for now - like you say they're almost certainly redirecting the URLs and if they ever stop then the omniauth provider will likely get fixed or a new one written or we can easily fork it if necessary.
There is actually omniauth-microsoft-office365 already which uses the new URLs and would probably work.
