merkaartor icon indicating copy to clipboard operation
merkaartor copied to clipboard

merkaartor 0.18 seems to allow empty tag value?

Open GerdP opened this issue 9 years ago • 3 comments

Hi! I found this changeset https://www.openstreetmap.org/changeset/36612297 where this node https://www.openstreetmap.org/node/3718637401 was changed with highway="" I think there is no good reason to safe an empty tag value.

ciao, Gerd

GerdP avatar Jan 17 '16 07:01 GerdP

Yes. I think this was a decision when I was redoing some logic in the tag manager.

In the 0.19 release, I plan to implement basic rules check before upload. This can be a thing to check, which would be a solution. Other solutions are:

  1. Delete the key as well as the tag if it's empty (I think this was the behavior before I changed it)
  2. Show dialog expaining what happened, possibly not allowing to finish the editation until it's either canceled or filled in (I would like to avoid necessary dialogs).
  3. Allow it, but show the tag name in red, perhaps with a tooltip informing it's not allowed.

I'd prefer solution 3, as it will fit nicely into the rules check I will implement later. I also would like to avoid adding features now, because I'm working on a 0.18.3 release (currently, I think all is done, I'm just trying to get Mac OS X packaging to work).

What do you think?

Krakonos avatar Jan 17 '16 09:01 Krakonos

I like the way JOSM does it: When you select a tag for editing, the dialog box shows the hint "(An empty value deletes the tag)" and that is what should happen IMHO

GerdP avatar Jan 17 '16 10:01 GerdP

Here too in v1. And here in v18 And we have the winner v1!

vlivyur avatar Sep 06 '23 12:09 vlivyur