id-tagging-schema
id-tagging-schema copied to clipboard
openstreetmap
Rethink handling of fenced=yes
Current behaviour
iD seems to produce warnigs for all objects with fenced=yes that look like
because of
https://github.com/openstreetmap/id-tagging-schema/blob/b947fd62cc17535b5b89b3f31cc92ac962ea90e4/data/deprecated.json#L646-L647
If the user executes the option to "upgrade the tags". iD replaces fenced=yes with barrier=fence on the same object.
Why this is not a good idea
fenced=yes is a tag mainly for area features, most of the objects tagged with it do also have an area tag, mostly landuse=* or leisure=*. In contrast, barrier=fence is a tag for a linear feature (a fence). For these objects, replacing fenced=yes with barrier=fence produces objects that are tagged with an area and a linear feature tag mixed together. This is generally discouraged, explained in these discussions:
- https://github.com/openstreetmap/iD/issues/7271
- [Tagging] Feature Proposal - RFC - net for sports pitches f
Possible solutions
- Replace the current option to "upgrade the tags" with another one that produces a separate way with
barrier=fence(and its attributes, if present). There is already a similar option for nodes that are part of a way but shouldn't:
Also objects that already have got these mixed area and linear tags should be handled. - Don't do anything in case of
fenced=yesand ignore its deprecation (until some better solution than the current one is available). - Question whether
fenced=yesshould be deprecated at all.
I agree, that most of the time one should map the fence separate from the area (in fact in my experience very few areas are actually fenced all the way around).
However, I don't see an issue with having an "area-feature" + barrier=fence, if mapping the fence separately is for some reason not feasible (at this point in time).
However(2), I do see an issue with having two tags that describe the same thing. So I agree with the deprecation and upgrade-nudge.
I agree, that having a "magic feature" that migrates the old tagging to a "two separate but connected geometries"-solution, would be an even better "deprecation" / upgrade path. But that is a complex feature to build…
The possibility for a single feature to be an area and a linear feature at the same time is a gotcha that many data consumers have run into and needed to work around, because it isn’t interoperable with other GIS formats and schemas. The workaround is usually to synthesize a coincident feature (representing just the barrier=fence in this case). OSM’s data model doesn’t prevent someone from dual-tagging a feature in this manner, but iD shouldn’t encourage it. I think it would make a lot more sense to separate the two features, even if that means an area would be glued to a line all the way around: https://github.com/openstreetmap/iD/issues/8263#issuecomment-749279400.
I agree, that having a "magic feature" that migrates the old tagging to a "two separate but connected geometries"-solution, would be an even better "deprecation" / upgrade path. But that is a complex feature to build…
Validator rules and fixes are implemented downstream in the iD codebase. If the “crossing ways” rule’s “Connect these ways” fix is any guide, a similar “Redraw the fence as a line around this area” fix should be relatively straightforward. The “outdated tags” rule is powered by the data in this repository, but any fix more complex than a simple tag replacement should be tracked in the openstreetmap/iD repository.
However(2), I do see an issue with having two tags that describe the same thing.
fenced=yes and barrier=fenced don't "describe the same thing". just as covered=yes and building=* don't.
-
fenced=yesdescribes an object that is fenced (attribute) by another object (a fence) that does not necessarily need to be mapped. -
barrier=fencedescribes a fence object (feature), and what it fences in (e.g. a pitch) does not necessarily need to be mapped.
Other comparisns see here
Question whether fenced=yes should be deprecated at all.
FWIW, fenced has been documented as a deprecated tag since 2016 on the wiki: https://wiki.openstreetmap.org/wiki/Key:fenced. If anything, this discussion should be made outside of this repository.
I agree that the current deprecation rule doesn't really do the right thing for polygonal features. A fix would need to:
- remove the deprecation rule from this repository and
- implement a dedicated validation rule on the iD repository for it which adds a separate
barrier=fenceway around the area
fenced has been documented as a deprecated tag since 2016 on the wiki: https://wiki.openstreetmap.org/wiki/Key:fenced
It is not changing that mass replace with barrier=fence is making situation even worse.
Yes, wiki has/had (I edited it)
This feature has been labeled as deprecated. The recommended replacement is: barrier=fence.
at https://wiki.openstreetmap.org/wiki/Key:fenced but many OSM Wiki pages claim silly things and should not be followed blindly.
Question whether fenced=yes should be deprecated at all.
FWIW,
fencedhas been documented as a deprecated tag since 2016 on the wiki: https://wiki.openstreetmap.org/wiki/Key:fenced. If anything, this discussion should be made outside of this repository.
Do you need a decision about that outside of this repository before you change the handling in iD or do you want to do what you already have proposed (replace fenced=yes by barrier=fence on a new object).
For now, I go with how it is currently documented: replacing fenced=yes by a new barrier=fence object. But I would also be ok to remove that "tag upgrade rule" at some point in the future should the community consensus change such that fenced=yes is ok to be mapped (analogously to coveverd=yes for example).
The problem is that fenced=yes may be also applied where object is almost, but not entirely fenced or parts of perimeter is blocked by other features, such as buildings.
In such cases robotic adding barrier=fence around entire area does not help.
FWIW,
fencedhas been documented as a deprecated tag since 2016 on the wiki: https://wiki.openstreetmap.org/wiki/Key:fenced. If anything, this discussion should be made outside of this repository
The status of fenced=yes was changed to in use on June 14, 2023.
Maybe the deprecation rule in iD can be removed now.
When we remove the deprecation rule, do we want to also add a moreFields field for it? Otherwise editors will more or less ignore the tag. — Personally I am fine with it, since I (a) don't understand why we need it at all; (b) I am not aware of any data consumers that use it (one could always check for the fence-object itself); (c) I would not know to which id-tagging-schema presets to add it to and which to leave out (could be researched…).
I am not aware of any data consumers that use it
OpenTopoMap seems to render it, see:
- https://taginfo.openstreetmap.org/tags/fenced=yes#projects
- https://opentopomap.org/#map=17/49.4225/8.672
- https://www.openstreetmap.org/way/24975498#map=17/49.4225/8.672
- https://github.com/der-stefan/OpenTopoMap/blob/e4467cfc2064afc379b0f8e8360db1740099cca3/mapnik/styles-otm/barriers.xml#L1-L15
Maybe the deprecation rule in iD can be removed now.
I just realized that this was already done long ago (https://github.com/openstreetmap/id-tagging-schema/commit/910ef162adbadf9d2866473566654ad3f8a091e0). I had overlooked it because this issue remained open and the discussion continued. Sorry for the unnecessary noise.
When we remove the deprecation rule, do we want to also add a
moreFieldsfield for it?
Interesting idea, but I don't know.