id-tagging-schema icon indicating copy to clipboard operation
id-tagging-schema copied to clipboard
verified publisher icon openstreetmap

Add preset for `shop=nuts`

Open Dimitar5555 opened this issue 3 years ago • 4 comments

Is it possible to have a preset for shop=nuts despite it's very niche use (206 uses as of 2022-01-11)?

Dimitar5555 avatar Jan 11 '22 21:01 Dimitar5555

Why not…? We have at least one shop preset for shop=wigs with even lower usage. :sweat_smile:

tyrasd avatar Jan 18 '22 16:01 tyrasd

My concern is that iD doesn't show the brand preset when you search for it (see: https://nsi.guide/index.html?t=brands&k=shop&v=nuts). image At least it works when the name is set correctly. image

Dimitar5555 avatar Jan 18 '22 17:01 Dimitar5555

Hm, at first glance, this looks like a bug in the nsi/presets matching of iD, since adding a preset for shop=nuts doesn't seem to help.

tyrasd avatar Jan 18 '22 18:01 tyrasd

I've updated the NSI script to just generate a fallback preset (like shop=yes) if it doesn't match the specific preset in id-tagging-schema that it's looking for.

bhousel avatar Jan 18 '22 21:01 bhousel

@bhousel

I've updated the NSI script to just generate a fallback preset (like shop=yes) if it doesn't match the specific preset in id-tagging-schema that it's looking for.

Is there list of affected ones somewhere? Ideally proper shop values would be used, not shop=yes

(I just made PR adding shop=honey to iD presets and can make more similar ones)

https://github.com/openstreetmap/id-tagging-schema/issues/362 has some old data, not sure is there anything new appearing

matkoniecz avatar Apr 22 '23 10:04 matkoniecz