id-tagging-schema icon indicating copy to clipboard operation
id-tagging-schema copied to clipboard

`traffic_sign=variable_message` has two direction fields

Open Dimitar5555 opened this issue 1 year ago • 2 comments

Describe the bug traffic_sign=variable_message has two direction fields (one for direction and one for traffic_sign:direction.

To Reproduce

  1. Go to https://www.openstreetmap.org/edit#map=19/43.79918/25.91882
  2. Select node/12089459546

Expected behavior Only one field should show up. Possibly direction since it used on 1.8k elements with traffic_sign=variable_message (compared ~1k for traffic_sign:direction).

Screenshots I've entered values for the fields, to show that two tags are applied. image

Dimitar5555 avatar Aug 04 '24 12:08 Dimitar5555

Some research

The issue is that data/presets/traffic_sign/variable_message.json has two direction fields

  1. the explicit field https://github.com/openstreetmap/id-tagging-schema/blob/main/data/fields/direction_vertex.json
  2. the inherited/referenced field from https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/traffic_sign.json which is https://github.com/openstreetmap/id-tagging-schema/blob/main/data/fields/traffic_sign/direction.json for vertex (https://github.com/openstreetmap/id-tagging-schema/blob/main/data/fields/direction_point.json for points)

The fields/direction_vertex is there from the start – History. So is the fields/traffic_sign/direction – History

The fields/direction_vertex is used a lot – List The fields/traffic_sign/direction is used only once – List

Proposed solution

Given that research, I think the way to solve this is to remove the fields/traffic_sign/direction field and reference fields/direction_vertex for presets/traffic_sign/variable_message.

I will add a label "good first issue" to this.

tordans avatar Aug 10 '24 03:08 tordans

@Dimitar5555 @tordans open a new PR for this issue. kindly review it

raghav3615 avatar Sep 30 '24 07:09 raghav3615

Update: See https://github.com/openstreetmap/id-tagging-schema/pull/1351#issuecomment-2933486007 for more information

tordans avatar Jun 03 '25 05:06 tordans