id-tagging-schema icon indicating copy to clipboard operation
id-tagging-schema copied to clipboard

_emergency.json: Added check_date to fields

Open jpds opened this issue 10 months ago • 4 comments

This is used by consumers such as OpenAEDMap.

jpds avatar Mar 29 '24 20:03 jpds

:bento: You can preview the tagging presets of this pull request here.

github-actions[bot] avatar Apr 05 '24 14:04 github-actions[bot]

The check_date field has the "universal": true flag, and is therefore already available for all presets. This change would only affect AED features which do not have this tag already (then the universal field is "hidden" under "more fields"). Was is the intent of this PR to make it visible also if unset?

I'm just wondering why this preset should be handled differently compared to other features, like other emergency infrastructure like fire hydrants for example.

tyrasd avatar Apr 05 '24 15:04 tyrasd

Was is the intent of this PR to make it visible also if unset?

Yes, I hadn't thought about the other emergency things - do I just move it into _emergency.json ?

jpds avatar Apr 06 '24 20:04 jpds

good idea. let's try adding it to the generic _emergency.json preset

tyrasd avatar Apr 10 '24 14:04 tyrasd