id-tagging-schema icon indicating copy to clipboard operation
id-tagging-schema copied to clipboard

Add presets for ski jump tagging

Open olafkryus opened this issue 1 year ago • 2 comments

Added most important presets for ski jumping venue tagging – the in-run structure, the piste and the take-off edge.

olafkryus avatar Mar 23 '24 15:03 olafkryus

:bento: You can preview the tagging presets of this pull request here.

github-actions[bot] avatar Mar 27 '24 12:03 github-actions[bot]

Thanks, this looks quite good already. See a few suggestions inline.

Thanks for the feedback.
I've applied one patch, and provided more info on the other – please be the judge ;)

In addition, could you also add the option for ski_jumping to the sport field please?

Sure. Done: e2f42db

olafkryus avatar Mar 31 '24 23:03 olafkryus

I just reran the actions to the preview is there again.

List of examples cases: https://overpass-turbo.eu/s/1NO4

The last open issue from above was the naming. I agree it should be shorter. It is two lines now and hard to understand:

image

Please move relevant search terms to the aliases or terms https://github.com/ideditor/schema-builder?tab=readme-ov-file#preset-schema

Please also check if the OSM Wikidata item can be improved to better explain the tag usage (its in the screenshot). Here: https://wiki.openstreetmap.org/wiki/Item:Q16841

One thing I am unclear about is the tagging as area vs. line.

  • This example seems to work as intended https://pr-1176--ideditor-presets-preview.netlify.app/id/dist/#background=EsriWorldImagery&disable_features=boundaries&id=w187922757&locale=en&map=19.94/47.89814/8.11134

However when mapped as a line…

  • there is an error to remove tags
  • the preset does not apply
  • the help text and icon is different
image

Examples:

  • https://pr-1176--ideditor-presets-preview.netlify.app/id/dist/#background=EsriWorldImageryClarity&disable_features=boundaries&id=w270557257&locale=en&map=20.00/48.73621/10.10972
  • https://pr-1176--ideditor-presets-preview.netlify.app/id/dist/#background=swisstopo_swissimage&disable_features=boundaries&id=w794427489&locale=en&map=20.00/46.50609/7.68285

Another thing is, why the piste:type is not a field when using like https://pr-1176--ideditor-presets-preview.netlify.app/id/dist/#background=EsriWorldImagery&disable_features=boundaries&id=w187922757&locale=en&map=19.94/47.89814/8.11134 – Is this tagging wrong or is the field missing?

tordans avatar Jul 06 '24 13:07 tordans

Thanks for the feedback.

The last open issue from above was the naming. I agree it should be shorter. It is two lines now and hard to understand

I've changed it now to a simple "Ski Jumping Tower". I hope the additional info will be enough for the more unusual cases.

(I've also went with it and shortened "Ski Jumping Hill Take-Off Point" to just "Ski Jumping Take-Off")

Please move relevant search terms to the aliases or terms

I've made some changes to that, I hope they are in-line with what was expected.

Please also check if the OSM Wikidata item can be improved to better explain the tag usage

I've reworded descriptions for both Q16841 and Q21202, I hope they are a bit more clear now.

One thing I am unclear about is the tagging as area vs. line

Another thing is, why the piste:type is not a field when using like https://pr-1176--ideditor-presets-preview.netlify.app/id/dist/#background=EsriWorldImagery&disable_features=boundaries&id=w187922757&locale=en&map=19.94/47.89814/8.11134 – Is this tagging wrong or is the field missing?

As for the tagging:

  • piste:type=ski_jump is supposed to span the whole of the "piste", the path the athlete travels, so that would be from the very top of the in-run to the very end of the out-run at the bottom. A piste can be tagged either as a line following the "path" of travel, or as an outline of the whole area available to the athlete.
  • man_made=ski_jump is supposed to cover only the outline of the man-made structure. So most of the time it will cover only the outline of the in-run tower, or it will be omitted completely if the ski jumping hill is "natural" (the in-run follows the curve of a fortunately shaped slope)

Therefore, it follows that, in almost all of the cases, the above two tags should be applied to separate elements.

So, the examples provided above seem to be wrongly tagged, and that seems to be the source of the mentioned problems.

I hope the link below will serve as a better example (and a more interesting, informative one, since the situation is more complex as the out-run doubles as a football pitch in the summer):

https://pr-1176--ideditor-presets-preview.netlify.app/id/dist/#background=EsriWorldImagery&disable_features=boundaries&id=w1223388311&locale=en&map=18/47.32155/11.17741

olafkryus avatar Jul 06 '24 19:07 olafkryus

As for the tagging: (…) Therefore, it follows that, in almost all of the cases, the above two tags should be applied to separate elements. So, the examples provided above seem to be wrongly tagged, and that seems to be the source of the mentioned problems.

Thanks for explaining, @olafkryus. I wonder what the best way to handle this would be. Would you be up for creating a MapRoulette Challenge for those mistagged features, so the data gets fixed? My concern is that iD will display this very prominent message, but the actions on the message are wrong. And AFAIK, it is not easy to change those messages because they are autogenerated…

tordans avatar Jul 07 '24 06:07 tordans

I wonder what the best way to handle this would be. Would you be up for creating a MapRoulette Challenge for those mistagged features, so the data gets fixed? My concern is that iD will display this very prominent message, but the actions on the message are wrong.

@tordans: Fortunately, there were "only" about a few dozen of such cases worldwide, therefore I decided to fix them all on my own on a case-by-case basis.

So, it shouldn't be an issue anymore: https://overpass-turbo.eu/s/1NRb

olafkryus avatar Jul 07 '24 20:07 olafkryus

Fortunately, there were "only" about a few dozen of such cases worldwide, therefore I decided to fix them all on my own on a case-by-case basis.

Lucky me to pick two of them right away :-D. Thanks for the cleanup!


I think this looks good now and ready to be merged.

tordans avatar Jul 08 '24 06:07 tordans