id-tagging-schema icon indicating copy to clipboard operation
id-tagging-schema copied to clipboard

Add climbing presets + fields

Open zbycz opened this issue 1 year ago • 7 comments

Hi,

I'd love to map more climbing routes according the climbing schema on wiki. See the discussion in:

  • #31

This PR

This PR adds the viable minumum to tag climbing crags and climbing routes. I will add more features as needed in future (eg. bouldering, area, alternative tagging for crag and boulder etc).

I add only presets climbing/crag and climbing/route + climbing/route_bottom for start.

I built this PR with dist command and deployed an iD editor with those presets, so it can be tested thorougly. eg.

  • https://osm.zby.cz/id-climbing/#id=r17130664
  • https://osm.zby.cz/id-climbing/#id=r14497828

.

.

Climbing terminology

The taxonomy goes like this - it can be grouped by relations, or just by nearstanding nodes:

  • Climbing area
    • Climbing crag
      • Climbing route
      • Climbing route (start)
      • Climbing route (top) <-- in climbing terminology "top" is end of route
    • Climbing boulder
      • Climbing route
      • Climbing route (start)
      • Climbing route (top)

Number of items

preset name tags types from wiki #
Climbing area climbing = area node,area,relation <1k
Climbing crag climbing = crag node,relation 3k
↳ or natural = cliff
sport = climbing
node,way 7k
Climbing boulder climbing = boulder node,relation 1k
↳ or natural = stone
sport = climbing
node,area 1k
Climbing route climbing = route node,way 1k
Climbing route (start) climbing = route_bottom node 4k
Climbing route (top) climbing = route_top node <1k

zbycz avatar Feb 09 '24 13:02 zbycz

Everything should have sport=climbing, no?

endolith avatar Feb 10 '24 13:02 endolith

Thanks @endolith, very good point. I added the sport=climbing via the addTags property. You can test it in the demo iD editor.

zbycz avatar Feb 12 '24 14:02 zbycz

image

The grade options are always the same? No YDS in the US?

It complains about some points being on trails or cliffs:

2024-02-12 22_54_04-iD - osm zby cz_ – Range of Motion — Mozilla Firefox 2024-02-12 22_57_34-iD - osm zby cz_ – Cat in the Hat — Mozilla Firefox

But not others:

2024-02-12 22_57_52-iD - osm zby cz_ – Point — Mozilla Firefox

And doesn't show the same interface for them:

2024-02-12 22_52_42-iD - osm zby cz_ – LA Roof — Mozilla Firefox

endolith avatar Feb 13 '24 04:02 endolith

Thanks for the feedback, @endolith 🙂

ad grades) unfortunately tagging allows for different marks to be assigned for different grade systems. So we have to add a field for each of them in iD. I added the YDS, but in future it would perhaps make sense to create a custom iD field type (like type=multi), which would have better UX (user is not supposed to fill in all of them).

climbing:grade:uiaa=*
climbing:grade:french=*
climbing:grade:saxon=*
climbing:grade:yds_class=*

ad "It complains about some points being on trails or cliffs") Good point. I added vertex type for the route_bottom preset.

ad "But not others") I didn't create a preset for route_top for start, but it is easy now. I added the preset.

Please check it again in the iD demo, eg Cat in the Hat

zbycz avatar Feb 14 '24 06:02 zbycz

:bento: You can preview the tagging presets of this pull request here.

github-actions[bot] avatar Feb 14 '24 12:02 github-actions[bot]

@tyrasd Thank you very much for such a good review. Also I am glad I learned how to correctly propose fields, eg. that I should search taginfo first 🙂

Changes deployed to my id instance, eg:

  • crag relation: https://osm.zby.cz/id-climbing/#id=r17130664
  • crag relation: https://osm.zby.cz/id-climbing/#id=r14497828
  • crag line: https://osm.zby.cz/id-climbing/#id=w745451490
  • crag area: https://osm.zby.cz/id-climbing/#id=w743598029
  • route_bottom without name: https://osm.zby.cz/id-climbing/#id=n2351544812
  • route_bottom+route both with names: https://osm.zby.cz/id-climbing/#id=n4901371127 (Cat in a Hat)

While editing moreFields I also got an idea how to make them more usable: https://github.com/openstreetmap/iD/pull/10181

zbycz avatar Mar 29 '24 09:03 zbycz

Hi @tyrasd - just gently bumping this issue. 🙂 🙏

zbycz avatar Jun 21 '24 09:06 zbycz