iD icon indicating copy to clipboard operation
iD copied to clipboard

Continue drawing line or area at any point

Open 1ec5 opened this issue 2 years ago • 3 comments

The Continue operation now allows you to draw freely starting from any point along the line, not only its endpoints. It works on closed lines and areas, too. This makes the operation useful for more tasks, for example:

  • Refining a river with more detailed meanders
  • Updating a building with a newly constructed wing
  • Continuing to draw an area after you accidentally exit drawing mode by clicking twice

In recognition of the Continue operation’s expanded abilities, it has been renamed to Draw.

https://github.com/openstreetmap/iD/assets/1231218/dffc6d46-a60d-4f09-97b8-d444a56f113c

Fixes #2272.

1ec5 avatar May 26 '23 09:05 1ec5

Hey. Very cool! However… I had been "secretly" working on a very similar feature recently. My version has the additional functionality to allow to "fly" along a line (or area outline) without having to re-select the start-vertex of the segment to be improved (similar to how it was proposed in #760):

way-amend-tool

IMHO that functionality is quite important because in a typical use case (e.g. when improving the bends of a waterway or realigning of a path), one does typically want to work on more than just a single segment of a way.

We talked about this the last monthly community meetup, but I definitely should have announced that I had started working on it in the issue #2272 to avoid duplicate work on it. Sorry for that!

tyrasd avatar May 26 '23 10:05 tyrasd

Oh cool, I had totally forgotten about #760. If I’m interpreting your screen recording correctly, you can enter drawing mode and click on an existing adjacent node to move it during drawing mode, correct? That satisfies the use cases I had in mind and gets closer to the request for a gesture in https://github.com/openstreetmap/iD/issues/2272#issuecomment-366485669. I’m curious about how the user can exit edit mode using the mouse if it has this additional behavior. Presumably the user won’t always want to redraw the entire line to the very end.

I’ll leave this PR open for now to serve as a reference point, but I look forward to your better design!

1ec5 avatar May 26 '23 20:05 1ec5