openstreetmap
NSI suggestions are treated as valid when they are often not
URL
https://www.openstreetmap.org/edit?editor=id&node=3196433293#map=20/53.95187/-1.08486
How to reproduce the issue?
(related to https://github.com/openstreetmap/iD/issues/9528)
When iD makes an incorrect NSI suggestion, the language iD uses suggests that the NSI suggestion is likely correct (which is often untrue).
To reproduce:
Pick a cafe named after one of the most popular surnames in the country (Robinson). Edit with iD. iD says that it "looks like a common feature with nonstandard tags" and offers me the chance to "upgrade the tags"
This is wrong. Sometimes NSI suggestions could be considered as "upgrades" (adding a wikidata field maybe, or pushing a particular tag schema). This is not what is being suggested here - instead the suggestion is to change something mapped as one feature to another.
Screenshot(s) or anything else?
https://www.openstreetmap.org/node/3196433293/history
Which deployed environments do you see the issue in?
Released version at openstreetmap.org/edit
What version numbers does this issue effect?
2.25.1
Which browsers are you seeing this problem on?
Other (please specify)
This is what I see. If it's a different "Robinsons" just click the option for "Tag as not the same Robinsons"
That's the screen that I see too, but all of the text that iD displays here is wrong:
- Cafe Robinsons is not a standard feature with nonstandard tags - it's a different feature entirely to the one added to the NSI at https://github.com/osmlab/name-suggestion-index/pull/7007/files ).
- The suggested change is not an "upgrade"; it is a change from feature X to feature Y
- "Tag is not the same Robinsons" is also wrong, since the tag does not match!
See also https://github.com/osmlab/name-suggestion-index/issues/7844 , although as noted there the NSI update (that there is a chain of pubs in the northwest of England called Robinson's) is mostly correct.
When adding a POI from the Feature Type, an available branded logo will appear, which makes it a lot easier to see what the suggestion is.
In this case, however, while iD shows the suggested tags, I can see from a new user perspective that it's not overly clear that the new tag suggestions represent the brand Robinsons.
Would it be possible to apply any available logo within the warning / suggested area as well?
Normally, the feature type button (preset button) at the top does show the name and logo of the detected brand, but it doesn’t when the detected brand would match a different preset (in this case, Pub versus Coffee Shop).
Another problem is that “Cafe Robinsons” isn’t the same as “Robinsons”. Fuzzy matching can be useful sometimes, but this kind of match should be the responsibility of a matchNames in NSI, not the preset matching code here in iD. (The NSI entry has a matchName of “Robinson’s Brewery”, for instance.)
See https://community.openstreetmap.org/t/proposed-automated-edit-removal-of-crossing-markings-yes-tags-introduced-in-undiscussed-automated-edits/129614/4 - this is an ongoing problem
NSI has multiple mistakes or coverage is not full, which regularly results in nonsense suggestions.
It should be made clear that these are not certain to be correct.
