iD icon indicating copy to clipboard operation
iD copied to clipboard

Bug by disconnect function (split instead disconnect)

Open sun-geo opened this issue 3 years ago β€’ 2 comments

URL

https://www.openstreetmap.org/edit?node=483041878#map=21/40.75560/-74.08496

How to reproduce the issue?

  1. Go to https://www.openstreetmap.org/edit?node=483041878#map=21/40.75560/-74.08496
  2. right click the node and select "Disconnect" from context menu

Current situation: the small grey node (grey - means connected) turns to a bigger white (means something is split) node. Expected situation: the small grey node (grey - means connected) turns to a small white (means something is disconnected) node.

It seems the outer ring of the relation is split. My further investigation revealed that the faulty split seems only happened if the first node of the outer ring of such multipolygon relation is involved.

Screenshot(s) or anything else?

after-disconnect-node-is-split

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

current v2.21.1

Which browsers are you seeing this problem on?

Chrome, Firefox

sun-geo avatar Sep 22 '22 06:09 sun-geo

Similarly, when you select the first/last node of a closed line (such as a fence or turning loop) and choose Disconnect, it disconnects the beginning of the line from the end of the line. Visually, it results in a split, but at the data level, it’s just a disconnection. I always figured this was a feature rather than a bug, making it easier to open a line back up after accidentally turning it into a closed way. However, I can see how it would be confusing for an area or even a ring of a multipolygon. (After all, these are all just ordinary ways being interpreted specially.)

1ec5 avatar Sep 22 '22 07:09 1ec5

Similarly, when you select the first/last node of a closed line (such as a fence or turning loop) and choose Disconnect, it disconnects the beginning of the line from the end of the line. Visually,

Interesting, never noticed this, but you are right. In this case, these kind of special nodes, where the first node and the last node of a way connects the way to a closed ring, should/could have another distinct (from white and grey) color?

sun-geo avatar Sep 23 '22 12:09 sun-geo