iD icon indicating copy to clipboard operation
iD copied to clipboard

survey_point shouldn't be moved

Open Bibi56 opened this issue 3 years ago • 2 comments

URL

https://www.openstreetmap.org/edit?editor=id&node=669983383#map=19/49.75438/4.87604

How to reproduce the issue?

  1. Open the link
  2. Read the misleading proposed "correction"

Screenshot(s) or anything else?

As stated in the note (for survey points in France): Ne pas déplacer ce point, cf. - Do not move this node, see - http://wiki.openstreetmap.org/wiki/WikiProject_France/Repères_Géodésiques#Permanence_des_rep.C3.A8res (...)two geodetic points at the same position (latitude, longitude) should not be merged, their altitudes (ele) being different.

More generally, two points at the same geographical position (latitude, longitude) but different elevation (ele) should not be candidate for a move: they are at the same geographical position by construction/design.

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.21.1

Which browsers are you seeing this problem on?

Firefox

Bibi56 avatar Aug 23 '22 22:08 Bibi56

More generally, two points at the same geographical position (latitude, longitude) but different elevation (ele) should not be candidate for a move: they are at the same geographical position by construction/design.

A specific exception for survey points makes sense to me, but a more general exception when ele differs would be trickier. I also suggested a more general exception back in https://github.com/openstreetmap/iD/issues/6612#issuecomment-508309223. However, sometimes there is a legitimate issue when two coincident points differ in elevation. For example, the GNIS import often put two nodes in the same place, one representing the dam and the other representing the reservoir impounded by it. The difference with survey points is that sometimes they’re supposed to be stacked one atop another, as in your example.

As a workaround, you could set layer to 1 and 2. Perhaps the warning should have a suggestion to tag the feature with a higher or lower layer, just as when a road crosses a building. However, layer would feel redundant to ele for something like this.

Tangentially, I wonder if man_made=survey_point should be locked by default so that the user can’t move it by mistake when panning the map, since they’re often mapped with more precision and intentionality than other point features. Holding down Alt (Option) would let the user move it intentionally.

1ec5 avatar Aug 23 '22 22:08 1ec5

Yes, locking the position of a man_made=survey_point, may be even its removal (if you do it you must know what you're doing) would make sense. No problem for having to add layer for the other rare cases.

Bibi56 avatar Aug 24 '22 18:08 Bibi56