iD icon indicating copy to clipboard operation
iD copied to clipboard

Bing Streetside shows white box

Open boothym opened this issue 3 years ago • 4 comments

Recently Bing Streetside has been showing a white box when you click on one of the blue dots. The following error is in the console (the second error only appeared when I ticked the high resolution box). If I click on the "view on bing maps" then I can see it on bing.com without any problems. bingerror

boothym avatar Aug 03 '22 23:08 boothym

I'm having the same problem. Noticed that it affects mainly new (2019-2021) pictures and doesn't affect old ones (2014-2015). Screenshot 2022-08-17 at 14 36 56 Screenshot 2022-08-17 at 14 37 45

dobatovkin avatar Aug 17 '22 11:08 dobatovkin

It might be caused by a different Firefox extension, check out #9211.

DujaOSM avatar Aug 17 '22 13:08 DujaOSM

@DujaOSM I'm using Chrome so...

boothym avatar Aug 17 '22 13:08 boothym

I'm getting this error in the console:

image

Which looks like it's referring to this line of code: https://github.com/openstreetmap/iD/blob/e66edcbc997a33963b108153da6d0f88d8a11573/modules/services/streetside.js#L285

AnonymousAlligatorOSM avatar Sep 07 '22 00:09 AnonymousAlligatorOSM

Which looks like it's referring to this line of code:

Thanks for pinpointing the error. This is the callback for a request to https://dev.virtualearth.net/mapcontrol/HumanScaleServices/GetBubbles.ashx . All the items in data look like this:

{
  "data": {
    "face": "01",
    "url": "https://t.ssl.ak.tiles.virtualearth.net/tiles/hs1003022022233211010.jpg?g=6338&n=z",
    "x": 0,
    "y": 0
  },
  "status": "error"
}

Each of these image URLs returns HTTP 200 with an empty response body.

As microsoft/MicrosoftStreetsidePlugin#8 shows, this issue is not specific to any extension or browser, but it is limited to the newer images that Microsoft has sourced from TomTom.

This article from the other day documents an official API for getting Streetside images and metadata. This support answer confirms that the “bubble” API endpoint we’re hitting is unsupported:

https://github.com/openstreetmap/iD/blob/cb1202883f907ae9a89b479ea04da10956a45711/modules/services/streetside.js#L20

1ec5 avatar Oct 21 '22 20:10 1ec5

There's been changes made in RapiD by @bhousel to apparently fix this issue: https://github.com/facebook/RapiD/commit/602cb771761f3e40dda0709b0b73dee515a61407 - can the same be done for iD?

boothym avatar Feb 01 '23 22:02 boothym

I've applied the workaround used in RapiD… It's not really a good solution, because we should actually replace the undocumented API calls with Bing streetview's v8 API (see https://github.com/openstreetmap/iD/issues/8747#issuecomment-945669204). But it seems to do the job for now.

tyrasd avatar Apr 04 '23 12:04 tyrasd

406c1a0690377de93715765c8628d470d4bab90c works, but it does no good without a release (#9729). Over the past several months, I’ve had to show scores of new mappers how to work around this bug (or switch to Rapid) just to be able to contribute productively in an urban area where Mapillary and KartaView have insufficient side-facing coverage.

1ec5 avatar Jul 06 '23 04:07 1ec5