iD icon indicating copy to clipboard operation
iD copied to clipboard
verified publisher icon openstreetmap

Mapillary images don't load with Firefox extension "Facebook Container"

Open waldyrious opened this issue 3 years ago • 3 comments

URL

Any edit URL. For the screenshots below, I'm using this: https://www.openstreetmap.org/edit?node=249204043#map=19/16.67432/-22.93507

How to reproduce the issue?

  • Open iD using Firefox with the Facebook Container add-on installed
  • Enable the Mapillary photo overlay
  • Click on one of the images

Screenshot(s) or anything else?

Without the Facebook Container add-on:

image

With the Facebook Container add-on activated:

image

Console output (screenshot):

image

Console output (text): 
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t6/An-U86xHpUOP3dRXoMUlYUuH7AwL8bUOW2gwzVapBXhmfA0Jf8rjkBLeBarjxNKISQ6SBnCjK-3_qsoqWoshT4Fjv-4wa3Ro4x4HZib2jrAccEj0T0Re0NZaeWqWFnjWZFAOys2mHWFnIPOXQ-1wb10?stp=s1024x576&ccb=10-5&oh=00_AT_S83TVp067ib6CIEhRMt9NVHo-FVT1KTEOw50qhjEqSw&oe=62E0E78C&_nc_sid=122ab1. (Reason: CORS request did not succeed). Status code: (null).

Failed to cache image (576761167283807). MapillaryError: Request error: https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t6/An-U86xHpUOP3…b6CIEhRMt9NVHo-FVT1KTEOw50qhjEqSw&oe=62E0E78C&_nc_sid=122ab1
    Fm             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38
    onerror        https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    o              https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    oo             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    ao             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    getImageBuffer https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:57
https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:59:9232

mly3 MapillaryError: Request error: https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t6/An-U86xHpUOP3…b6CIEhRMt9NVHo-FVT1KTEOw50qhjEqSw&oe=62E0E78C&_nc_sid=122ab1
    Fm             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38
    onerror        https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    o              https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    oo             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    ao             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    getImageBuffer https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:57
https://www.openstreetmap.org/assets/iD/mapillary-js/id-0ac2d4ce47c510bb7126ddaaff5ce431b29900dd9c2a7c83badd8a7be7e7d453.js:61:27062

MapillaryError: Request error: https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t0.40361-6/An9Kj…F0qm70jYAjMkG347v65xa9K19887xYqXQ&oe=62E07E43&_nc_sid=d122da
    Fm             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38
    onerror        https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    o              https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    oo             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    ao             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    getMesh        https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:57
https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38:18468

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t0.40361-6/An9KjyDnlwxnx_08Z8s_pITqsht29Pa8i7dh2HFkLEWvFLPsoqip9_5c--dIP2seH60eDp13izil3k-l_oNADgfwXvo78h2OYAF6c83ybKyJUoISSZtHNtnCpI8fowzEBFU?ccb=10-5&oh=00_AT_QZneIfA94ZF0qm70jYAjMkG347v65xa9K19887xYqXQ&oe=62E07E43&_nc_sid=d122da. (Reason: CORS request did not succeed). Status code: (null).

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t6/An-U86xHpUOP3dRXoMUlYUuH7AwL8bUOW2gwzVapBXhmfA0Jf8rjkBLeBarjxNKISQ6SBnCjK-3_qsoqWoshT4Fjv-4wa3Ro4x4HZib2jrAccEj0T0Re0NZaeWqWFnjWZFAOys2mHWFnIPOXQ-1wb10?stp=s1024x576&ccb=10-5&oh=00_AT_S83TVp067ib6CIEhRMt9NVHo-FVT1KTEOw50qhjEqSw&oe=62E0E78C&_nc_sid=122ab1. (Reason: CORS request did not succeed). Status code: (null).

Failed to cache image (576761167283807). MapillaryError: Request error: https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t6/An-U86xHpUOP3…b6CIEhRMt9NVHo-FVT1KTEOw50qhjEqSw&oe=62E0E78C&_nc_sid=122ab1
    Fm             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38
    onerror        https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    o              https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    oo             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    ao             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    getImageBuffer https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:57
https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:59:9232

MapillaryError: Request error: https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t0.40361-6/An9Kj…F0qm70jYAjMkG347v65xa9K19887xYqXQ&oe=62E07E43&_nc_sid=d122da
    Fm             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38
    onerror        https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    o              https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    oo             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    ao             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    getMesh        https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:57
https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38:18468

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t0.40361-6/An9KjyDnlwxnx_08Z8s_pITqsht29Pa8i7dh2HFkLEWvFLPsoqip9_5c--dIP2seH60eDp13izil3k-l_oNADgfwXvo78h2OYAF6c83ybKyJUoISSZtHNtnCpI8fowzEBFU?ccb=10-5&oh=00_AT_QZneIfA94ZF0qm70jYAjMkG347v65xa9K19887xYqXQ&oe=62E07E43&_nc_sid=d122da. (Reason: CORS request did not succeed). Status code: (null).

Uncaught (in promise) MapillaryError: Request error: https://scontent.fopo3-2.fna.fbcdn.net/m1/v/t6/An-U86xHpUOP3…b6CIEhRMt9NVHo-FVT1KTEOw50qhjEqSw&oe=62E0E78C&_nc_sid=122ab1
    Fm             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38
    onerror        https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    o              https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    oo             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    ao             https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:21
    getImageBuffer https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:57
https://www.openstreetmap.org/assets/iD/mapillary-js/mapillary-1851af74bdd0596f9d1648cf72b9bd18d8a97d492b91c9c82dfb22f589dee90f.js:38:22440

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.21.1

Which browsers are you seeing this problem on?

Firefox

waldyrious avatar Jul 23 '22 08:07 waldyrious

For now, I've disabled the extension, as it seems it may not be needed anymore (although the fact that this bug doesn't occur without the extension shows that it's doing more than the default protections).

waldyrious avatar Jul 23 '22 08:07 waldyrious

This is not a bug, is it?

I think it can be closed and keep it as a FYI for others that may search for that issue.

tordans avatar Jul 23 '22 09:07 tordans

Yeah, this is not iD's fault. That said, I was wondering whether iD would want to implement the Mapillary functionality in a way that wouldn't be affected by this browser extension (assuming that's even technically possible), or at least guard for this case in the code and provide a more legible error in the browser console (or even better, in the interface) so that people with this issue can know how to resolve it.

waldyrious avatar Jul 23 '22 11:07 waldyrious