openstreetmap
Complain about "Unspecific primary tag value" (like barrier=yes) in validator
Description
Offer to replace it with more specific feature
Offer to split it into parts (does not apply to nodes and amenity=school barrier=yes taggings)
From https://github.com/openstreetmap/id-tagging-schema/issues/531
Screenshots
No response
BTW, the same can be done with say https://taginfo.openstreetmap.org/tags/traffic_calming=yes
Here's a quick list of all primary tag keys with their usage numbers of their yes value (only showing tags with usage numbers > 2k, and excluding building=yes for obvious reasons):
-
barrier=yes(129k) :white_check_mark: -
craft=yes(3k) -
emergency=yes(95k) [^1] -
healthcare=yes(13k) :white_check_mark: -
historic=yes(132k) [^1] -
landuse=yes(4k) -
leisure=yes(3k) -
man_made=yes(18k) :white_check_mark: -
military=yes(2k) -
natural=yes(5k) -
office=yes(73k) :white_check_mark: -
shop=yes(179k) :white_check_mark: -
tourism=yes(7k) -
traffic_calming=yes(13k) :white_check_mark: -
water=yes(5k)
Marked with :white_check_mark: are tags where the id-tagging-schema already includes a dedicated hidden <primary tag> (Unspecified Type) preset.
I guess what the validator could do is the following: If the primary tag(s) of an object all have the value yes (adding an exception for building=yes), show a warning/information about the lack of detail. That way a feature tagged as barrier=city_wall + historic=yes (or amenity=school + barrier=yes) would not be flagged.
[^1]: I'd assume that these tags might largely not be used as a primary tag (with the value yes), but rather as properties of other primary tags
Offer to split it into parts
What exactly do you mean by splitting into parts here? And how would it help to solve the issue?
What exactly do you mean by splitting into parts here? And how would it help to solve the issue?
It is possible that barrier=yes is partially representing barrier=fence and partially barrier=wall
In such case it should be split in pars before being tagged with more specific value.
Though maybe it can be assumed that user is capable of doing it with a general tools?
@tyrasd
Would it make sense to request adding "Unspecific Foobar" on iD tagging scheme issue tracker for this list from https://github.com/openstreetmap/iD/issues/9209#issuecomment-1192705808 ?
I've just added support for the remaining common ones (man_made, healthcare, traffic_calming, barrier) in addition to the previously existing ones (shop, office). I think the rest is reasonably uncommon (or used as an non-primary tag / attribute) to not need a dedicated preset IMHO.
I think it's sufficient to just implement the validator to show a hint about all of these (and the remaining primary tags like aerialway=yes, etc. as well).