iD
iD copied to clipboard
openstreetmap
create a 'divide' operation
This PR creates a "divide" operation, similar to the JOSM gridify plugin. It lets you divide an area into a grid of smaller areas. This is useful for mapping parking spaces, terraced houses, and camp pitches.
You can try it out here. Select an area and press K.
Closes #6988
https://user-images.githubusercontent.com/16009897/157165940-b2f6e20a-c885-4f74-8814-716f912a6c74.mp4
More Examples
| 
|
| 
|
Remaining issues:
- [ ] needs an icon
- [ ] needs a different shortcut instead of K
- [ ] Since this operation is only useful for a small number of features it should possibly be hidden by default?
Nifty, this will tempt me to start nanomapping the individual modules of solar panels. š
I wonder if it would be possible to replace the two prompts with something more interactive. Perhaps you hit the shortcut key, then move the mouse along the long and short axes to control the number of divisions. Itād be similar to how you can scrub the mouse cursor while rotating a feature, except that this gesture would snap to widths that evenly divide the area. For things like parking spaces, itād be more convenient to eyeball the right width than to count the divisions manually.
Since this operation is only useful for a small number of features it should possibly be hidden by default?
If we expect this operation to be used somewhat less frequently than, say, the merge operation, how about keeping it available in the context menu for all areas but avoid assigning a keyboard shortcut? Itās becoming ever more difficult to assign memorable single-key shortcuts without modifiers, especially in locales that translate them. Currently, operationsā availability depends on the selected geometry type, but it would be more difficult to communicate to the user that this operation depends on certain tags.
If we expect this operation to be used somewhat less frequently than, say, the merge operation, how about keeping it available in the context menu for all areas but avoid assigning a keyboard shortcut?
That's a good idea - my concern was also that it will clutter the context menu, which already has 8 items, but maybe that's not a problem...
I wonder if it would be possible to replace the two prompts with something more interactive. Perhaps you hit the shortcut key, then move the mouse along the long and short axes to control the number of divisions.
š I'll give this some thought, another option could be to replace the two prompts with a modal. That modal could have a preview similar to the turn-restriction editor. Both options will be quite complicated.
Probably out of scope for this PR, but may be worth considering as a follow up: Would be nice if this supported use of custom dividing line (something like: draw way across area, select both, perform divide operation). Useful for things like drawing a footprint and splitting into non-uniform buildings or building parts, or splitting land use to re-tag a section.
Would be nice if this supported use of custom dividing line (something like: draw way across area, select both, perform divide operation). Useful for things like drawing a footprint and splitting into non-uniform buildings or building parts, or splitting land use to re-tag a section.
Vector drawing tools have a similar operation. It isnāt the most discoverable, but it makes a lot of sense once youāre made aware of it, similar to how iD supports punching holes in polygons using the merge operation. In that case, you could even hook it up to the split operation, so you can select an area and a line that cuts across it, but donāt select a vertex, then split the area along the line. It would be quite outside the scope of this PR, but it might be worth considering how to make the UX for this feature consistent with what might be possible for that other feature.
This is looking superb! It'd be nice if it could split based on the bbox instead of the actual nodes, but that can be implemented after this :)
A case where splitting with bbox would be useful:
It would be nice if we could also do this with ways, for if we know there's windows/doors or extensions along a building wall.
