iD icon indicating copy to clipboard operation
iD copied to clipboard

Switch all pure math/vector methods to use the iD SDK.

Open Bonkles opened this issue 4 years ago • 2 comments

This is the first in a potential series of PRs to cut iD over to use the iD-SDK math library (https://www.npmjs.com/package/@id-sdk/math).

The iD-SDK is an effort to reduce the amount of code that needs to be cloned/forked for downstream projects from iD to do their work effectively.

This PR does the following:

  • Removes the geo/vector code and unit tests (they're now embedded within the SDK, so no need to keep them in iD's codebase
  • Replaces those methods / imports with SDK referenced methods

Bonkles avatar Sep 08 '21 19:09 Bonkles

Assuming I need to log an issue with iD-SDK, how would I do that? Right now GitHub tells me that’s limited to collaborators.

An owner of this repository has limited the ability to open an issue to users that are collaborators on this repository.

mmd-osm avatar Sep 09 '21 12:09 mmd-osm

Assuming I need to log an issue with iD-SDK, how would I do that? Right now GitHub tells me that’s limited to collaborators.

An owner of this repository has limited the ability to open an issue to users that are collaborators on this repository.

Good point! As this is the first time the code will be 'public' and in use, we should change that policy and allow folks to submit issues.

UPDATE: You should now have the option in the repo to submit issues.

Bonkles avatar Sep 09 '21 16:09 Bonkles