iD icon indicating copy to clipboard operation
iD copied to clipboard

Notes: Filter / Only notes I contributed to

Open tordans opened this issue 7 years ago • 7 comments

The analysis at https://www.openstreetmap.org/user/joost%20schouppe/diary/43057 suggests that a lot of notes are personal notes. I sometimes use them this way as well as a kind of reminder.

The UI could help with that by providing a filter that only shows notes that I contributed to (created or commented).

One way for this might be to extend the UI where I activate the notes layer to a radio button group

(x) No notes (..) All notes (..) Notes that I contributed to

However, such a UI would not extend well with something like https://github.com/openstreetmap/iD/issues/5171

bildschirmfoto 2018-07-24 um 07 07 37

tordans avatar Jul 24 '18 05:07 tordans

What about "(..) Notes i did not contribute to" ?

manfredbrandl avatar Jul 24 '18 08:07 manfredbrandl

related #5153

bhousel avatar Jul 24 '18 14:07 bhousel

@bhousel, @tordans, and @manfredbrandl, I've started working on preliminary filters for the notes layer. You can take a look at the notes-filtering branch. Settings are found by clicking the ellipses next to the notes layer under Map Data.

image

thomas-hervey avatar Dec 21 '18 22:12 thomas-hervey

@thomas-hervey great to see progress on this, thanks. I tried running it locally to test it out but did not manage to get it working. Might be just my tech skills. Just in case I will email you a screen-grab video; maybe that helps finding a bug that is not just for me locally.

Just a few first thoughts based on your screenshot:

a. What will the indicator look like that tells me "this nodes layer has active filter" once the notes-data-settings-layer is closed? Does the UI element allow a light gray subline to list the filter? bildschirmfoto 2018-12-22 um 08 41 24

b. Is status and status-daterange really something different? Right now I could miss-configure "status open + status daterange closed before 12/12/2012".

  • An easy solution might be to just have the date range in the second block and derive the status from the first block. The label could then be "Notes <status,eg"opened"> after" (Min) and "Notes <status,eg"opened"> before" (Max).
  • Other UI elements would be even nicer, but I think also a lot more UI-work.

c. Is the usecase of "Maximum" daterange really important? It makes the filter quite a bit harder to understand. I think the main use case is "show recent notes", so only the min-filter.

tordans avatar Dec 22 '18 07:12 tordans

Thanks @tordans, a. There isn't an indicator yet, but I plan to add an indicator for hidden notes, like that of hidden features: screen shot 2018-12-26 at 11 53 34 am

b. I think the status & status date-range are different because a user may want to look at a combination. For example, if I want to look at notes that have been previously closed but are currently open (having been reopened), I think it's best to have two selectors. But I am still working on this list of options. c. I agree, a min & max isn't necessarily the best option. I was experimenting with date pickers and thought that it allowed the best fine tuning. However, moving the max date range could certainly be done.

thomas-hervey avatar Dec 26 '18 18:12 thomas-hervey

There are quite some workflows, like mapping parties, or tools like Tasking Manager or MapRoulette which use hashtags for traceability.

So, OSM Notes should also be filtered by a free text and/or a hashtag.

sfkeller avatar Feb 16 '19 22:02 sfkeller

I would like to add a suggestion. And that is to show notes with a different colour such as orange if they have comments. Reason is that when I'm closing notes I want to close all the red notes, but some of them I've questioned the notes what they mean, so then It would be helpful to have a different colour to distinguish them from other notes.

CharliePlett avatar Aug 22 '24 14:08 CharliePlett