iD icon indicating copy to clipboard operation
iD copied to clipboard

Use convenience store icons directly

Open jidanni opened this issue 1 month ago • 4 comments

It's so easy. https://github.com/alltheplaces/alltheplaces.xyz/issues/76#issuecomment-3639593666

jidanni avatar Dec 11 '25 01:12 jidanni

can you provide a bit more info please, perhaps using one of the issue templates?

iD already uses icons from NSI everywhere except in the map-renderer itself.

k-yle avatar Dec 12 '25 11:12 k-yle

Well perhaps see https://github.com/openstreetmap-carto/openstreetmap-carto/issues/3828 . I'm just saying might as well use a store's chain's icon instead of a generic icon. Even if only for the brief time an editor is editing.

jidanni avatar Dec 12 '25 12:12 jidanni

iD already supports this for well-known brands:

Image Image

if you want to add a missing brand, you'll need to raise an issue at osmlab/name-suggestion-index

k-yle avatar Dec 12 '25 13:12 k-yle

Yes, https://www.openstreetmap.org/edit?node=6062365721#map=22/24.1758150/120.7205220 I see it on the left, I'm just saying it should also appear on the right.

Same problem with https://www.openstreetmap.org/edit?node=2307997435#map=22/24.1757740/120.7196280

As you see, the logo only appears in the panel, not on the map. Bug!

Now on the map look at the SWEAR store directly to the west.

It doesn't have a registered logo. Thus in both the panel and on the map it uses the same generic logo, left side and right side of the screen. No problem here.

I'm saying in all cases the logo should be the same on both sides of the screen: panel and map.

jidanni avatar Dec 12 '25 18:12 jidanni

By the way,

if you want to add a missing brand, you'll need to raise an issue at osmlab/name-suggestion-index

Alas, I am on the long list of people the owner has blocked, so someone else needs to add the brand on https://www.openstreetmap.org/way/368940461 there for me.

jidanni avatar Dec 13 '25 04:12 jidanni