remove pointless dependency

Open k-yle opened this issue 3 weeks ago • 1 comments

When constructing a CDN URL for NSI assets, NSI's version number is parsed with "vparse", and then the semver-patch part is removed.

As far as I can tell, this extra parsing is not required, because the jsdeliver CDN supports any semver syntax. None of the other assets do this extra parsing.

cc @bhousel, since this you added this because of https://github.com/openstreetmap/iD/pull/8305#discussion_r663055241

Dec 05 '25 12:12 k-yle

Yeah this is fine, good suggestion @k-yle 👍

I remember adding this in 8db1c1f mostly because Milos asked for it here https://github.com/openstreetmap/iD/pull/8305#discussion_r662213728

I remember being weakly against the idea of having code that automatically references the dependencies in package.json, but I didn't really have a strong opinion and didn't want to hold up the PR, so I added it.

My opinion is still that urls like these should be updated manually (by a human) and with intention.

Dec 05 '25 14:12 bhousel