iD icon indicating copy to clipboard operation
iD copied to clipboard

Cannot see documentation for diet: tags

Open paulklie opened this issue 1 month ago β€’ 3 comments

URL

https://github.com/openstreetmap/id-tagging-schema/issues/1739

How to reproduce the issue?

  1. Open a restaurant node
  2. Click the "info" button for diet types.

No information from the wiki is found.

Screenshot(s) or anything else?

Based on the original discussion in https://github.com/openstreetmap/id-tagging-schema/issues/1739

The data seems to be correct in the id-tagging-shema, instead it seems like id does not correctly load key prefixes, see https://github.com/openstreetmap/id-tagging-schema/issues/1739#issuecomment-3548366734

Image

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

No response

Which browsers are you seeing this problem on?

Firefox

paulklie avatar Nov 21 '25 14:11 paulklie

Hi! I'd like to work on this issue. I can investigate why the key prefixes aren’t loading correctly and ensure the diet type documentation is fetched properly. Could you please assign this to me?

Thanks!

SatyamKumarCS avatar Nov 21 '25 16:11 SatyamKumarCS

I investigated this issue and confirmed the problem is caused by iD not resolving prefixed keys like diet:* correctly when generating wiki documentation URLs.

Currently the tag reference loader does not properly construct wiki paths for keys containing prefixes, so diet:vegan fails to load:

Expected: https://wiki.openstreetmap.org/wiki/Key:diet:vegan

Proposed fix: Update the wiki resolver logic to always include the full key (including prefixes) when generating the Key URL.

I can prepare a patch that:

Correctly resolves prefixed keys like diet:*

Adds fallback to base key if the specific page is missing

Please let me know if you'd like me to open a PR with this fix.

βœ… Result After Fix

βœ” diet tags load wiki help βœ” No more blank info panel βœ” Proper documentation displayed βœ” Consistent behaviour with other prefixed tags

chavarahul avatar Nov 22 '25 05:11 chavarahul

I thought this was fixed in https://github.com/openstreetmap/iD/pull/11402 Is this something different that than?

tordans avatar Nov 22 '25 06:11 tordans