iD icon indicating copy to clipboard operation
iD copied to clipboard

Change the validation rule with overlapping buildings

Open maro-21 opened this issue 7 months ago • 5 comments

When two buildings overlap, it is usually a mistake to be corrected manually, i.e. the buildings are actually standing next to each other, but have been connected inaccurately. Don't let the iD editor suggest to add layer=1 or layer=-1, because people mindlessly click it and strange silly things come out. The warning can stay, but without suggesting adding a layer. Cases where one building is above another are very rare.

maro-21 avatar May 18 '25 12:05 maro-21

Yeah, adding layer tags to overlapping buildings rarely properly addresses the underlying map data quality issue of building features. It might actually be better to omit those fixes in this particular case.

tyrasd avatar May 21 '25 10:05 tyrasd

Agree; the proposal to fix by setting a layer is unhelpful and should be removed.

I think the problem should be reported to the user, as it's almost always a drawing error, but with only a suggestion to redraw.

mvl22 avatar May 25 '25 23:05 mvl22

there are some tag combinations where it would make sense to keep the layer quickfixes.

For example, it's common for building=roof to overlap other buildings. Also building=yes + amenity=shelter to a lesser degree

k-yle avatar May 26 '25 00:05 k-yle

I've occasionally seen (semi-)underground parking mapped as overlapping buildings, like here: https://www.openstreetmap.org/way/180842312

tyrasd avatar May 27 '25 13:05 tyrasd

I think the problem should be reported to the user, as it's almost always a drawing error, but with only a suggestion to redraw.

Exactly. In my city one billion buildings were imported and they often overlap. The fix is usually to remove one node. But many beginners see this error and they "fix" it by adding layer=1/-1

maro-21 avatar Jun 01 '25 21:06 maro-21