iD
iD copied to clipboard
:bug: Warn on same layer crossing regardless of bridge / tunnel
Fixes #10631
Shoutout to the project, it was really easy to setup a dev environment on GitHub Codespace and run iD and its test!
Here you can see the new check working:
- One way is a bridge, the other is not
- Both have the same defined layer
- => The warning is raised
Should I improve / change anything here?
This is something for Martin to review IMO.
Looks like I cannot assign you @tyrasd
@tyrasd do you want me to do anything to help getting this merged? Like adding tests? Feel free to asks and possibly suggest some changes.
To sum up a bit the changes:
- The main change is to warn if 2 elements have the same defined
layerand intersect - I rewrote the
tunnel/bridgepart to be more concise and explicit (and to remove the case that is already handled by (1)) - The
buildingpart is already included in the more general check (1) as discussed in https://github.com/openstreetmap/iD/pull/10999#discussion_r2063755697 - I added 2 tests for the above changes, all the other tests are untouched
if there are no objections, i think this could be merged