iD icon indicating copy to clipboard operation
iD copied to clipboard

"Road crosses Road" warnings disappear even when not resolved

Open DujaOSM opened this issue 1 year ago • 3 comments

URL

https://tools.geofabrik.de/osmi/?view=routing&lon=20.45357&lat=44.54193&zoom=13&baselayer=Geofabrik%20Standard&overlays=unconnected_open_ends_1

How to reproduce the issue?

No response

Screenshot(s) or anything else?

RoadXRoad

  1. Create a section of e.g. Tertiary Road connected to an existing road
  2. Create 3 sections of e.g. Residential Roads connected to it, as in the screenshot
  3. Select the Tertiary road and [D]isconnect it from everything. "Residential Road is very close to Tertiary" and "Residential Road crosses Tertiary" appear 3 times each, as expected.
  4. Select one warning and resolve it by "Connect the features"
  5. All other warnings now disappear without being resolved (there aren't warnings for the two bottom roads anymore).

You can re-trigger validation for one road by e.g. slightly moving its point, but you have to know it is invalid in the first place.

Background: I was cleaning up a rather large area by disconnecting roads from landuse, counting on iD to warn me on (near-)crossings and offer reconnecting roads to roads. Since it mostly didn't, I created over 50 routing errors in e.g. changeset 161131307.

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.30.4

Which browsers are you seeing this problem on?

Firefox

DujaOSM avatar Jan 10 '25 09:01 DujaOSM

Please note that the provided URL at the top will stop showing the errors soon as they are going to be fixed. Therefore here is screenshot as it looks today: image

ratrun avatar Jan 10 '25 13:01 ratrun

Yeah, there seems to be something odd going on: When I tried to replicate the bug, I noticed that for some of the disconnected nodes there are no warnings shown at all. :thinking: Apparently, iD does currently not reliably find situations where two roads meet at nodes with different node id, but the same coordinates

tyrasd avatar Jan 14 '25 09:01 tyrasd

I have been reusing this trick recently (disconnecting and reconnecting roads using the warning system) out of despair (someone has glued everything in sight), but with iD 2.37.3 it seems to work fine -- all adjacent disconnected roads are now reported correctly, and there aren't new warnings on OSM Inspector of my own making.

It's possible that this was a side effect of another fix. So, I plan to test this a bit more and eventually close the issue, unless you beat me to it -- perhaps you have an idea what fixed this?

DujaOSM avatar Nov 28 '25 10:11 DujaOSM