iD icon indicating copy to clipboard operation
iD copied to clipboard

Merging two ways corrupts step_count

Open danieldegroot2 opened this issue 1 year ago • 1 comments

URL

No response

How to reproduce the issue?

Follow-up to #8069

Splitting a way in two results in i.e. step count of 4 => 3+1 / 2+2 depending on the length of the way itself. However, merging two ways will result in 3+1 => Error (values are not the same), or 2+2 => 2 (merged, values are not summed) Perhaps summing up the values, or alternatively (prompting to) delete the values (if situation has changed significantly), is better.

See also https://github.com/MarcusWolschon/osmeditor4android/issues/1251#issuecomment-706021265

Screenshot(s) or anything else?

No response

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.30.4

Which browsers are you seeing this problem on?

Chrome

danieldegroot2 avatar Oct 10 '24 15:10 danieldegroot2

A similar issue is merging ways tagged parking:left/right/both:capacity=*. Summing the values sounds reasonable to me, though this assumes that the preexisting split doesn’t correspond to the location of one of the steps being counted twice. Refusing to merge also seems OK, though it would be annoying to the user without clear guidance on how to resolve the conflict.

1ec5 avatar Oct 11 '24 10:10 1ec5

I’d like to work on this issue. Could you assign it to me?

haresahani avatar Oct 29 '24 16:10 haresahani

Hey @haresahani , kindly let me know if you're still working on it.

Deeptanshu-sankhwar avatar Dec 04 '24 22:12 Deeptanshu-sankhwar

@Deeptanshu-sankhwar , @haresahani anyone of you working on this issue?

Darshit42 avatar Dec 23 '24 17:12 Darshit42

Not as of now, feel free to pick it @Darshit42

Deeptanshu-sankhwar avatar Dec 28 '24 09:12 Deeptanshu-sankhwar

@danieldegroot2 @k-yle @1ec5 I have gone through @Darshit42 approach #10633, and I would like to suggest we can fix the unintended consequences by restricting to certain tags. Also we can introduce taking average/min/max value for certain tags. Should I proceed with this issue and raise a pr?

chaitanyakadu avatar Mar 23 '25 07:03 chaitanyakadu

@1ec5 @tyrasd @tordans @k-yle @danieldegroot2 can you kindly review the pr and let me know if additional modifications are needed!

chaitanyakadu avatar Mar 29 '25 21:03 chaitanyakadu