iD icon indicating copy to clipboard operation
iD copied to clipboard

Allegedly 3 relations, 4 are shown

Open SomeoneElseOSM opened this issue 1 year ago • 11 comments

URL

https://www.openstreetmap.org/edit?node=12003612260#map=20/53.23114/-4.17875

How to reproduce the issue?

Click the link. Click on the cycleway to the right https://www.openstreetmap.org/way/1295390144 . "Relations (3) but 4 are shown

Screenshot(s) or anything else?

Screenshot_20240625_105009

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.29.0

Which browsers are you seeing this problem on?

Firefox

SomeoneElseOSM avatar Jun 25 '24 09:06 SomeoneElseOSM

That way is part of 3 unique relations. Notice that it's part of "Lon Las Cymru" twice which most likely isn't correct.

Dimitar5555 avatar Jun 25 '24 10:06 Dimitar5555

https://www.openstreetmap.org/way/1295390144 was added twice to https://www.openstreetmap.org/relation/5487292

This seems like a data issue...

mmd-osm avatar Jul 13 '24 10:07 mmd-osm

This seems like a data issue...

Absolutely - but the data issue is what I am trying to fix with iD!

SomeoneElseOSM avatar Jul 13 '24 10:07 SomeoneElseOSM

I seem to be able to remove the duplicate assignment by either clicking on the first or second delete icon in your screenshot. Afterwards, the UI would list three relations and the title would also show "Relations (3)". Wouldn't this resolve the issue?

Maybe it would be better to edit the relation instead, since one duplicate way member appears at the very end of the relation member list (where it probably doesn't belong).

mmd-osm avatar Jul 13 '24 10:07 mmd-osm

One more thing - iD doesn't tell me that a way is in the relation twice, only that it is in two relations that have the same name. This is because iD refuses to show relation numbers.

SomeoneElseOSM avatar Jul 13 '24 10:07 SomeoneElseOSM

We have a ticket about that, probably multiple. But yes, when a relation is listed twice in the same list of memberships, or when an element is listed twice in the same list of members, an extra bit at the end indicating the ID would be reasonable. Better yet, hovering over one of the entries could highlight the other matching entries somehow.

1ec5 avatar Jul 13 '24 16:07 1ec5

Please - not something that depends on mouse hover. It's not discoverable and it discriminates against those less deft with a mouse, or using a trackpad without having got the hang of it yet.

SomeoneElseOSM avatar Jul 13 '24 16:07 SomeoneElseOSM

The two ideas aren’t mutually exclusive.

1ec5 avatar Jul 13 '24 17:07 1ec5

iD doesn't tell me that a way is in the relation twice, only that it is in two relations that have the same name

This could be solved by collapsing the multi-membership like this:

tyrasd avatar Sep 02 '24 13:09 tyrasd

This could be solved by collapsing the multi-membership like this:

That does say "it is in the same relation twice", but doesn't say what relation that is or whether that is a problem or not. The relevant issues for the first part are https://github.com/openstreetmap/iD/issues/10343#issuecomment-2324726977 and https://github.com/openstreetmap/iD/issues/8559 , and it's pointless to even think about the second part until those are resolved.

SomeoneElseOSM avatar Sep 02 '24 13:09 SomeoneElseOSM

whether that is a problem or not.

Not quite sure if I can follow: How could the relation membership editor help to find out whether there is a problem? It already says that this particular relation is a route, where multiple membership is at least in principle allowed. Showing something else (like the ref or network tags, or even the relation's id) would not necessarily help with this, or would it?

tyrasd avatar Sep 02 '24 13:09 tyrasd