iD icon indicating copy to clipboard operation
iD copied to clipboard

Tag values over 255 characters long are silently truncated in raw tag editor

Open fabi003 opened this issue 1 year ago • 4 comments

URL

https://www.openstreetmap.org/node/11829238608/history

How to reproduce the issue?

Enter a tag value longer then 255 characters, as tag value for some key and then upload the changeset.

They value of the tag will be truncated after upload.

This easily occurs when writing complex opening_hours=* with comments, as common e.g. for German physicians (after I hit the 255 char limit limit the 2nd time, I report it now). You can also look at the the German opening_hours=*-page (machine translated), if you need some more complex rule examples.

Screenshot(s) or anything else?

The user should be notified about this and the actual length of the values over the 255 character limit should be displayed in some kind to help to shorten the comments or remove some whitespaces.

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.29.0

Which browsers are you seeing this problem on?

Firefox

fabi003 avatar May 12 '24 20:05 fabi003

Duplicate of #4061

riQQ avatar May 12 '24 20:05 riQQ

@fabi003: Did you not get the warning message that the entered value is longer than 255 characters? It should look something like this:

image

tyrasd avatar May 27 '24 11:05 tyrasd

If I pasted the opening hours into the input fields in the above picture, I got this warning (I found it out after this issue report). If I paste the opening_hours=* into the generic tag editor, what I do in most times, when adding/editing tags, I don't get any warnings.

fabi003 avatar May 27 '24 15:05 fabi003

ok, I didn't think about the raw tag editor. There should be a similar indicator and warning also in those input fields.

tyrasd avatar May 29 '24 09:05 tyrasd

I have a suggestion solution, I want to get your opinion before implementing it.

The solution is to change the max chars tag value from 255 to 510 or any number bigger than this number.

MohamedAli00949 avatar Apr 03 '25 17:04 MohamedAli00949