iD icon indicating copy to clipboard operation
iD copied to clipboard

Hide turn restriction UI from `highway=crossing` for footway

Open tordans opened this issue 1 year ago • 3 comments

URL

https://ideditor.netlify.app/#background=Bing&disable_features=boundaries&id=n8677399770&locale=en&map=20.00/52.28422/13.53982

How to reproduce the issue?

  1. open https://ideditor.netlify.app/#background=Bing&disable_features=boundaries&id=n8677399770&locale=en&map=20.00/52.28422/13.53982
  2. see the turn restriction UI which does not make any sense for this node image

This actually allows to create "no u turn" restrictions on the crossing node:

image

Screenshot(s) or anything else?

No response

Which deployed environments do you see the issue in?

Development version at ideditor.netlify.app

What version numbers does this issue effect?

No response

Which browsers are you seeing this problem on?

Chrome

tordans avatar Apr 26 '24 09:04 tordans

I don't think this is related to crossings specifically. You can get the turn restriction UI for any place where highways meet even when those highways are not supposed to appear in the UI.

RudyTheDev avatar Apr 29 '24 21:04 RudyTheDev

See #9983

Dimitar5555 avatar Apr 29 '24 22:04 Dimitar5555

See #9983

Thanks @Dimitar5555 this could very well be a regression in https://github.com/openstreetmap/iD/commit/ea47581bae335ace9f117216c1882da8a26b4852 ~Looking at the same node in Rapid (which does not have this change) the Turn-Restriction UI does not show up https://rapideditor.org/canary#map=20.00/52.28422/13.53982&background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries&id=n8677399770&locale=en~

  • Update: I learned that Rapid does not have the turn restriction UI at all … so that test is not helpful :-)

@tyrasd I think ea47581bae335ace9f117216c1882da8a26b4852 should be reverted and the corresponding issue reopened. Having the UI show up too often is worse then having an edge case where it does not show at all, IMO.

tordans avatar Apr 30 '24 04:04 tordans

Having the UI show up too often is worse then having an edge case

It could be possible to hide the field in such cases, but still make it available to add manually via the Add field box.

tyrasd avatar Mar 18 '25 09:03 tyrasd