minicap icon indicating copy to clipboard operation
minicap copied to clipboard

Set the maximum FPS support

Open codeskyblue opened this issue 8 years ago • 3 comments

This is a feature request

What is the issue or idea you have? It is a good news that minicap support render 30~40fps per second. Actually on some devices the render speed can reach 60fps. But high fps means high network load. I hava tries to limit the FPS(<=30) in stf. but maybe the best way is set the maximum FPS in minicap.

Assume the usage example:

minicap -F 30 -P 1920x1080@960x540/0

Yours sincerely

codeskyblue avatar Dec 04 '17 01:12 codeskyblue

I will accept a PR that does this (as long as it does it reasonably well), but due to limited time and other restrictions I can't work on it directly.

sorccu avatar Dec 04 '17 01:12 sorccu

It would definitely be helpful for STF feature request 1063 KaiOS devices are not very powerfull and continuously making screenshots makes my device restart the main process (not the phone) ...

I slightly modified minicap to limit the frame rate. If there is no ongoing work on that topic, I am willing to discuss the changes I made to see if it does well enough and contribute it. Don't know if I missed something, but a few lines and a std::this_thread::sleep_until in the main loop seems to do the job. Tell me if you prefer to discuss on a PR or here.

pcrepieux avatar Jun 27 '19 16:06 pcrepieux

In case, you find it fulfills this need, I created #183

pcrepieux avatar Jul 19 '19 13:07 pcrepieux