adbkit icon indicating copy to clipboard operation
adbkit copied to clipboard

used decaffeinate to convert coffeescript into javascript

Open phapdinh opened this issue 5 years ago • 4 comments

Hi @sorccu I started on the conversion of the coffeescript files into javascript. I don't know if every conversion is valid, but I am open to helping out as much as I can.

phapdinh avatar Sep 20 '19 02:09 phapdinh

I appreciate the effort but I’m hoping for a better conversion than just running decaffeinate and calling it a day. At least the decaf suggestions should be addressed.

sorccu avatar Sep 20 '19 04:09 sorccu

And the coffeescript dependency and build scripts should be removed.

There is an older branch where this was attempted. You can look at that for reference.

sorccu avatar Sep 20 '19 04:09 sorccu

I can take the javascript files that are generated from grunt and replace the coffeescript files with those files instead of using decaffeinate. Those javascript files are what are actually used in production

phapdinh avatar Sep 20 '19 12:09 phapdinh

I can create a separate PR for that one

phapdinh avatar Sep 20 '19 12:09 phapdinh