openstatus icon indicating copy to clipboard operation
openstatus copied to clipboard

Badge might not look sharp

Open thibaultleouay opened this issue 9 months ago • 4 comments

Reproduction / Replay Link (Optional)

No response

Description

image

it looks a bit pixelated

Environment

No response

thibaultleouay avatar May 02 '24 12:05 thibaultleouay

image

looks good to me @thibaultleouay

Sama-004 avatar May 04 '24 18:05 Sama-004

@Sama-004 on our page we are using the react widget

The SVG is the one with issue

thibaultleouay avatar May 04 '24 18:05 thibaultleouay

hey @thibaultleouay would like to work on this.

Abbhiishek avatar May 08 '24 11:05 Abbhiishek

@Abbhiishek would love that

It's in this file

https://github.com/openstatusHQ/openstatus/blob/7d3b31f1af50d92e82df87f3f6571e266119516a/apps/web/src/app/status-page/%5Bdomain%5D/badge/route.tsx#L12

maybe one size is wrong we should probably have multiple size as argument ?

thibaultleouay avatar May 08 '24 13:05 thibaultleouay

hey @thibaultleouay

locally cloning the repo fails due to invalid path. I have attached logs below:

error: invalid path 'apps/docs/api-reference/incident/get-incident:id.mdx'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

Even when i tried checking out to main, the same thing happened.

> git checkout -q main
error: invalid path 'apps/docs/api-reference/incident/get-incident:id.mdx'
error: invalid path 'apps/docs/api-reference/incident/put-incident:id.mdx'
error: invalid path 'apps/docs/api-reference/monitor/delete-monitor:id.mdx'
error: invalid path 'apps/docs/api-reference/monitor/get-monitor:id.mdx'
error: invalid path 'apps/docs/api-reference/monitor/get-monitor:id/summary.mdx'
error: invalid path 'apps/docs/api-reference/monitor/put-monitor:id.mdx'
error: invalid path 'apps/docs/api-reference/notification/get-notification:id.mdx'
error: invalid path 'apps/docs/api-reference/page/get-page:id.mdx'
error: invalid path 'apps/docs/api-reference/page/post-page:id/update.mdx'
error: invalid path 'apps/docs/api-reference/page/put-page:id.mdx'
error: invalid path 'apps/docs/api-reference/status_report/delete-status_report:id.mdx'
error: invalid path 'apps/docs/api-reference/status_report/get-status_report:id.mdx'
error: invalid path 'apps/docs/api-reference/status_report/post-status_report:id/update.mdx'
error: invalid path 'apps/docs/api-reference/status_report_update/get-status_report_update:id.mdx'

Abbhiishek avatar May 23 '24 12:05 Abbhiishek

@Abbhiishek are you on windows?

thibaultleouay avatar May 23 '24 12:05 thibaultleouay

@Abbhiishek are you on windows?

yep :)

Abbhiishek avatar May 23 '24 12:05 Abbhiishek

This has been fix you can specify a size for the badge

badge?size=sm with the following variable

  • sm
  • md
  • lg
  • xl

thibaultleouay avatar May 30 '24 15:05 thibaultleouay