openstack-exporter icon indicating copy to clipboard operation
openstack-exporter copied to clipboard

"tenant" label to cinder_volume_gb metric

Open az-blip opened this issue 1 month ago • 5 comments

Hi, I needed the tenant name label in the cinder_volume_gb to make so regex aggregation, so I suggest a patch to add it. In order to map the tenant id into name, I created a function in keystone.go to generate a map. Il could be reused for the same need in other metrics. I also adapted the tests, they seem to be ok. Tell me if you see something that need to be modified.

Thank you, best regards.

az-blip avatar Nov 13 '25 17:11 az-blip

Hey @az-blip . Thanks for this!

We use GPG signing in this repo, you will need to force-commit with verified commits. Let me know if you need help with this.

Sharpz7 avatar Nov 13 '25 22:11 Sharpz7

Hi, After an intense struggle, I think I finally managed to sign my commits without messing up the repository. Please let me know if it seems ok or if I have to fix something else.

az-blip avatar Nov 14 '25 11:11 az-blip

Thanks @az-blip ! Just the tests to do.

I appreciate getting verified commits is a pain, sadly that is out of my control (I am a maintainer not an admin)

Sharpz7 avatar Nov 16 '25 05:11 Sharpz7

Hi, I fixed the two linter errors. Running the workflow in my forked repository now ends in the "Build and test" step because I didn't configure the registry credentials. I assume (and hope ;) ) it will run smoothly in this repository.

az-blip avatar Nov 17 '25 10:11 az-blip

Apoligies for it not auto running @az-blip , it will after your first contribution - which is hopefully soon!

Thanks again :)

Sharpz7 avatar Nov 17 '25 16:11 Sharpz7