openssl icon indicating copy to clipboard operation
openssl copied to clipboard
verified publisher icon openssl

CMS: add missing CLI failure message; fix micalg output for SHAKE and GostR3411 - backport

Open DDvO opened this issue 11 months ago • 5 comments

This backports the most important code fixes (and the minor doc fix) of #27368: On error signing and outputting a CMS structure, the CMS app so far does not show any error report, and the micalg output goes wrong for SHAKE and GostR3411.

DDvO avatar May 05 '25 18:05 DDvO

Thank you @beldmit for your 2nd approval on #27368. Can you please also review this small backport?

DDvO avatar May 12 '25 13:05 DDvO

@t8m fine with this very limited backport?

DDvO avatar May 14 '25 06:05 DDvO

The newly shown merge conflict is not really one - it just appeared because the main PR #27368 is meanwhile merged and I forgot to base this backport PR on an earlier branch: openssl-3.5. Yet when merging there and earlier branches, this conflict will not be present.

DDvO avatar May 14 '25 07:05 DDvO

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

openssl-machine avatar Jun 14 '25 00:06 openssl-machine

I'd be OK with this backport. Could you please retarget this against the openssl-3.5 branch?

t8m avatar Jun 16 '25 08:06 t8m

@t8m wrote:

I'd be OK with this backport. Could you please retarget this against the openssl-3.5 branch?

Sorry, I had overlooked for a while this comment; done now.

DDvO avatar Jul 12 '25 13:07 DDvO

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

openssl-machine avatar Aug 13 '25 00:08 openssl-machine

This pull request is ready to merge

openssl-machine avatar Aug 14 '25 16:08 openssl-machine

Merged to the 3.5, 3.4, 3.3, 3.2 and 3.0 branches. Thank you for your contribution.

t8m avatar Aug 18 '25 16:08 t8m