openssl Cleanups for FIPS options..

The options in fipsprov.c are now generated using macros with fips_indicator_params.inc. This should keep the naming consistent.

Some fips related headers have moved to providers/fips/include so that they can use fips_indicator_params.inc. securitycheck.h now includes fipsindicator.h, and fipsindicator include fipscommon.h.

fipsinstall.c uses OSSL_PROV_PARAM_ for the configurable FIPS options rather than using OSSL_PROV_FIPS_PARAM_* as this was confusing as to which one should be used. fips_names.h just uses aliases now for existing public names.

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

Aug 12 '24 09:08 slontis

Fixed the style checks for non macro lines.

Aug 12 '24 23:08 slontis

Looks like there is a intermittent test issue not related to this PR.

Aug 23 '24 03:08 slontis

rebased

Aug 25 '24 22:08 slontis

Build oops.

Aug 25 '24 22:08 paulidale

Its a new file change.. So rebase worked fine..

Aug 25 '24 22:08 slontis

A thought: would it be worthwhile including the fipsinstall options as part of the .inc processing? Keeps all the mutable stuff together. It could also fold into the fipsinstall test. Essentially taking a final cleansing step.

For a future PR if we decide we do want this.

Aug 26 '24 02:08 paulidale

Ping @openssl/committers for second review please.

Aug 26 '24 21:08 paulidale

This pull request is ready to merge

Aug 28 '24 11:08 openssl-machine

Merged to the master branch. Thank you for your contribution.

Aug 28 '24 12:08 t8m