openssl icon indicating copy to clipboard operation
openssl copied to clipboard

Add vector support detecting for linux64-loongarch64

Open heiher opened this issue 8 months ago • 5 comments

Fixes #23003

heiher avatar Dec 11 '23 11:12 heiher

CLA sent

heiher avatar Dec 11 '23 12:12 heiher

Please remove this line: https://github.com/openssl/openssl/pull/21510/files#diff-cfb77b1f843910cbcc75a53d1e387ab16a6a630beff34c95978e22ca3a16317aR687 and the related $disable probing above it. (I added the detection at the wrong place and with your change it can be removed.)

xry111 avatar Dec 18 '23 13:12 xry111

How does the other architectures handle the issue?

With Perl scripts it might be easy (?) to rewrite the vector instructions with some Perl functions emitting .word <instruction code>...

xry111 avatar Dec 18 '23 13:12 xry111

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

openssl-machine avatar Jan 18 '24 00:01 openssl-machine

This PR is in a state where it requires action by @openssl/committers but the last update was 61 days ago

openssl-machine avatar Feb 18 '24 00:02 openssl-machine

This PR is in a state where it requires action by @openssl/committers but the last update was 92 days ago

openssl-machine avatar Mar 20 '24 00:03 openssl-machine

How does the other architectures handle the issue?

With Perl scripts it might be easy (?) to rewrite the vector instructions with some Perl functions emitting .word <instruction code>...

Yes, that is what other architectures usually do.

t8m avatar Apr 12 '24 06:04 t8m

rewrite the vector instructions with some Perl functions emitting .word ...

See for example https://github.com/openssl/openssl/blob/master/crypto/modes/asm/aes-gcm-armv8-unroll8_64.pl#L7351 - but we try to use .inst if that is available

tom-cosgrove-arm avatar Apr 12 '24 07:04 tom-cosgrove-arm

This PR is waiting for the creator to make requested changes but it has not been updated for 30 days. If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

openssl-machine avatar May 13 '24 00:05 openssl-machine

This PR is waiting for the creator to make requested changes but it has not been updated for 61 days. If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

openssl-machine avatar Jun 13 '24 00:06 openssl-machine

This PR has been closed. It was waiting for the creator to make requested changes but it has not been updated for 90 days.

openssl-machine avatar Jul 12 '24 00:07 openssl-machine