openssl icon indicating copy to clipboard operation
openssl copied to clipboard

Published 20 hours ago • verified publisher icon openssl

Fix hang on Windows in x509 policy code

Open paulidale opened this issue 3 years ago • 5 comments

This reverts commit 9aa4be691f5c73eb3c68606d824c104550c053f7.

Fixes #19643

paulidale avatar Nov 10 '22 22:11 paulidale

A test will probably work only in tsan or on Windows. But yeah, it would be useful.

t8m avatar Nov 11 '22 08:11 t8m

Testcase added.

I suspect getting the test/pkits-test.pl script running as a unit test would be better. I've raised this as #19663.

paulidale avatar Nov 13 '22 23:11 paulidale

Are there licence and/or CLA issues with just including the PKITS test data in our codebase?

mattcaswell avatar Nov 14 '22 09:11 mattcaswell

They come from NIST which generally mean fair game to use. We've a lot of other NIST test cases already.

paulidale avatar Nov 14 '22 10:11 paulidale

They come from NIST which generally mean fair game to use.

We should check this with OMC.

mattcaswell avatar Nov 14 '22 10:11 mattcaswell

OMC: Inclusion of this test data is ok to proceed.

mattcaswell avatar Nov 30 '22 08:11 mattcaswell

FYI https://csrc.nist.gov/projects/pki-testing is the web page from which the test data is located.

t-j-h avatar Nov 30 '22 08:11 t-j-h

@paulidale could you please move the testcase to test_cms recipe? It does not look to me it should be in test_threads as it does not really spawn any threads.

t8m avatar Nov 30 '22 09:11 t8m

Relocated.

paulidale avatar Dec 04 '22 23:12 paulidale

ping for second review

t8m avatar Dec 07 '22 08:12 t8m

This pull request is ready to merge

openssl-machine avatar Dec 08 '22 09:12 openssl-machine

Merged to master, 3.1, and 3.0 branches. Thank you.

t8m avatar Dec 08 '22 10:12 t8m