Do proper error handling of strtonum

Open AZero13 opened this issue 2 years ago • 3 comments

Checking for an error string is the proper step, rather than checking for 0. Have an error string for consistency.

Jul 04 '23 21:07 AZero13

@daztucker Fixed!

Jul 05 '23 13:07 AZero13

I've applied the cast change, but as I said above I do not see the need for the rest of this change since the existing error check is unambiguous. Can you give an example of when the existing code does the incorrect thing?

Jul 06 '23 22:07 daztucker

You did not address my previous comment: " I do not see the need for the rest of this change since the existing error check is unambiguous. Can you give an example of when the existing code does the incorrect thing?"

Jul 09 '23 12:07 daztucker