fhircore icon indicating copy to clipboard operation
fhircore copied to clipboard

Support interpolation for `conditionalFhirPathExpression` to filter resources

Open LZRS opened this issue 1 year ago • 1 comments

To pass in evaluated rule variables

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3537

Engineer Checklist

  • [ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • [ ] I have added any strings visible on UI components to the strings.xml file
  • [ ] I have updated the CHANGELOG.md file for any notable changes to the codebase
  • [ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • [ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • [ ] I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • [ ] I have verified Unit tests have been written for any new feature(s) and edge cases
  • [ ] I have verified any strings visible on UI components are in the strings.xml file
  • [ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • [ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • [ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

LZRS avatar Oct 04 '24 13:10 LZRS

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 27.3%. Comparing base (8cf03cf) to head (0ade5f3).

Files with missing lines Patch % Lines
...re/engine/rulesengine/ResourceDataRulesExecutor.kt 66.6% 0 Missing and 3 partials :warning:
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3538   +/-   ##
=======================================
  Coverage     27.2%   27.3%           
- Complexity     756     757    +1     
=======================================
  Files          278     278           
  Lines        14219   14223    +4     
  Branches      2581    2583    +2     
=======================================
+ Hits          3880    3883    +3     
  Misses        9801    9801           
- Partials       538     539    +1     
Flag Coverage Δ
engine 63.8% <66.6%> (+<0.1%) :arrow_up:
geowidget 15.4% <ø> (ø)
quest 5.6% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...re/engine/rulesengine/ResourceDataRulesExecutor.kt 84.4% <66.6%> (-0.6%) :arrow_down:

codecov[bot] avatar Oct 04 '24 13:10 codecov[bot]