fhircore icon indicating copy to clipboard operation
fhircore copied to clipboard

Add CALCULATE_DISTANCE_RULE_EXECUTOR LocationLogOption to Application_Config

Open qiarie opened this issue 9 months ago • 1 comments

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3275

Engineer Checklist

  • [ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • [ ] I have added any strings visible on UI components to the strings.xml file
  • [ ] I have updated the CHANGELOG.md file for any notable changes to the codebase
  • [ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • [ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • [ ] I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • [ ] I have verified Unit tests have been written for any new feature(s) and edge cases
  • [ ] I have verified any strings visible on UI components are in the strings.xml file
  • [ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • [ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • [ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

qiarie avatar May 16 '24 13:05 qiarie

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 28.0%. Comparing base (ac82739) to head (f302030). Report is 64 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3276     +/-   ##
=========================================
- Coverage     29.6%   28.0%   -1.7%     
- Complexity     658     690     +32     
=========================================
  Files          239     264     +25     
  Lines        11204   12398   +1194     
  Branches      1948    2164    +216     
=========================================
+ Hits          3323    3477    +154     
- Misses        7447    8462   +1015     
- Partials       434     459     +25     
Flag Coverage Δ
engine 64.9% <100.0%> (-1.4%) :arrow_down:
geowidget 18.7% <ø> (-28.5%) :arrow_down:
quest 5.2% <0.0%> (-0.2%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...gister/fhircore/engine/rulesengine/RulesFactory.kt 70.1% <100.0%> (+0.7%) :arrow_up:
...gister/fhircore/engine/util/SharedPreferenceKey.kt 100.0% <100.0%> (ø)
...register/fhircore/quest/ui/login/LoginViewModel.kt 1.6% <0.0%> (-0.1%) :arrow_down:
...register/fhircore/quest/ui/main/AppMainActivity.kt 1.3% <0.0%> (-1.1%) :arrow_down:

... and 11 files with indirect coverage changes

codecov[bot] avatar May 16 '24 13:05 codecov[bot]