fhircore
fhircore copied to clipboard
Load icons / Image Enhancement
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes [link to issue]
Engineer Checklist
- [ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
- [ ] I have added any strings visible on UI components to the
strings.xmlfile - [ ] I have updated the CHANGELOG.md file for any notable changes to the codebase
- [ ] I have run
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guide - [ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
- [ ] I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.
Code Reviewer Checklist
- [ ] I have verified Unit tests have been written for any new feature(s) and edge cases
- [ ] I have verified any strings visible on UI components are in the
strings.xmlfile - [ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
- [ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
- [ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app
Codecov Report
Attention: Patch coverage is 0% with 56 lines in your changes are missing coverage. Please review.
Project coverage is 29.3%. Comparing base (
ac82739) to head (6f8e6ff). Report is 55 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #3242 +/- ##
=========================================
- Coverage 29.6% 29.3% -0.3%
- Complexity 658 693 +35
=========================================
Files 239 252 +13
Lines 11204 11955 +751
Branches 1948 2093 +145
=========================================
+ Hits 3323 3512 +189
- Misses 7447 7982 +535
- Partials 434 461 +27
| Flag | Coverage Δ | |
|---|---|---|
| engine | 64.8% <ø> (-1.4%) |
:arrow_down: |
| geowidget | 47.2% <ø> (ø) |
|
| quest | 5.5% <0.0%> (+<0.1%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files | Coverage Δ | |
|---|---|---|
| ...egister/fhircore/quest/ui/main/AppMainViewModel.kt | 5.1% <0.0%> (+0.6%) |
:arrow_up: |
| ...ster/fhircore/quest/ui/profile/ProfileViewModel.kt | 8.2% <0.0%> (-0.4%) |
:arrow_down: |
| ...ister/fhircore/quest/ui/shared/components/Image.kt | 0.0% <0.0%> (ø) |
|
| ...fhircore/quest/util/extensions/ConfigExtensions.kt | 0.0% <0.0%> (ø) |