fhircore icon indicating copy to clipboard operation
fhircore copied to clipboard

Added the performer and organization info for consent resource along …

Open Aleem92 opened this issue 1 year ago • 2 comments

…with unit tests (#3227)

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • [ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • [ ] I have added any strings visible on UI components to the strings.xml file
  • [ ] I have updated the CHANGELOG.md file for any notable changes to the codebase
  • [ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • [ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • [ ] I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • [ ] I have verified Unit tests have been written for any new feature(s) and edge cases
  • [ ] I have verified any strings visible on UI components are in the strings.xml file
  • [ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • [ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • [ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Aleem92 avatar May 02 '24 17:05 Aleem92

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.3%. Comparing base (83595aa) to head (0c8e9fa).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3230     +/-   ##
=========================================
- Coverage     28.3%   28.3%   -0.1%     
  Complexity     716     716             
=========================================
  Files          266     266             
  Lines        12760   12764      +4     
  Branches      2265    2269      +4     
=========================================
+ Hits          3621    3622      +1     
- Misses        8666    8667      +1     
- Partials       473     475      +2     
Flag Coverage Δ
engine 64.9% <0.0%> (-0.1%) :arrow_down:
geowidget 19.8% <ø> (ø)
quest 4.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...hircore/engine/util/extension/ResourceExtension.kt 67.2% <0.0%> (-0.6%) :arrow_down:

codecov[bot] avatar May 02 '24 17:05 codecov[bot]

Fix the failing tests @Aleem92

ellykits avatar May 14 '24 13:05 ellykits