fhircore icon indicating copy to clipboard operation
fhircore copied to clipboard

[Validation] Add validation to flag to the user if multiple Composition resource match a given identifier name

Open f-odhiambo opened this issue 1 year ago • 4 comments

Issue: Users may add (un-knowingly) multiple versions of the same configuration by adding multiple composition resources to HAPI instead of using the previously uploaded one and relying on versioning to track the changes made to the same resource. At the moment the app picks the top item in the array if this were to happen but it is not a sure way to know wether that is the most appropriate resource to use as the latest working version

Acceptance criteria

  1. Alert the user if multiple Composition resources match a given identifier

NB. May require user training to enforce the correct way of versioning of resources rather than adding multiple versions

f-odhiambo avatar Feb 12 '24 08:02 f-odhiambo

@qiarie This might be something we want to think about while scoping for versioning too.

dubdabasoduba avatar Feb 12 '24 12:02 dubdabasoduba

This is noted @dubdabasoduba

qiarie avatar Feb 12 '24 13:02 qiarie

I kind of don't think the client is the appropriate place to worry about this. Like if you're a user and you get this alert, most likely you won't know what it means.

Seems better to config/extend HAPI to only allow 1 composition (or whatever unit of app we use in the future, eg IG) per appID

pld avatar Feb 12 '24 20:02 pld

I kind of don't think the client is the appropriate place to worry about this. Like if you're a user and you get this alert, most likely you won't know what it means.

Seems better to config/extend HAPI to only allow 1 composition (or whatever unit of app we use in the future, eg IG) per appID

@pld I think we can extend the Gateway to return an error if it finds multiple compositions of type App Config for the same identifier

This we do not affect any other use of the Composition in the future

dubdabasoduba avatar Feb 14 '24 07:02 dubdabasoduba