fhircore
fhircore copied to clipboard
Add the new eCBIS flavor | main
IMPORTANT: Where possible all PRs must be linked to a Github issue
- This addition will allow our client to install apps targetting the preview server and the prod server on the same device.
- The logos on the preview APK have been changed for clarity on what each APK does
Engineer Checklist
- [ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
- [ ] I have added any strings visible on UI components to the
strings.xml
file - [ ] I have updated the CHANGELOG.md file for any notable changes to the codebase
- [ ] I have run
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guide - [ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
- [ ] I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.
Code Reviewer Checklist
- [ ] I have verified Unit tests have been written for any new feature(s) and edge cases
- [ ] I have verified any strings visible on UI components are in the
strings.xml
file - [ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
- [ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
- [ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 60.6%. Comparing base (
ac82739
) to head (52cb3b6
). Report is 202 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2610 +/- ##
==========================================
+ Coverage 29.6% 60.6% +30.9%
- Complexity 658 1067 +409
==========================================
Files 239 247 +8
Lines 11204 9979 -1225
Branches 1948 1778 -170
==========================================
+ Hits 3323 6049 +2726
+ Misses 7447 2897 -4550
- Partials 434 1033 +599
Flag | Coverage Δ | |
---|---|---|
geowidget | 18.7% <ø> (-28.5%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@dubdabasoduba Do we still need to merge this PR?
Closing this since it's longer needed