openspeech icon indicating copy to clipboard operation
openspeech copied to clipboard

`OpenspeechCTCModel.forward`: `self.fc` is undefined

Open kuraga opened this issue 1 year ago • 3 comments

Good day!

https://github.com/openspeech-team/openspeech/blob/10b25890b64b722c50aa7579c2570ad5c69b2cf2/openspeech/models/openspeech_ctc_model.py#L118

self.fc is not defined,is it?

Which in_features, out_features should it have?

cc @upskyy , @sooftware

kuraga avatar Oct 20 '24 19:10 kuraga

@kuraga It should be defined as below link, but there seems to be a missing issue in the jasper model.

https://github.com/openspeech-team/openspeech/blob/main/openspeech/models/contextnet/model.py#L71 https://github.com/openspeech-team/openspeech/blob/main/openspeech/models/conformer/model.py#L66

upskyy avatar Oct 21 '24 03:10 upskyy

@upskyy , thanks for the reply! But as far as I understand, there is no the constant encoder_dim... Should we calculate it?

kuraga avatar Oct 21 '24 08:10 kuraga

See https://github.com/sooftware/jasper/issues/4#issuecomment-2449833556.

kuraga avatar Oct 31 '24 13:10 kuraga