opensourcediversity.org icon indicating copy to clipboard operation
opensourcediversity.org copied to clipboard

Fix failing HTML checks

Open jwflory opened this issue 3 years ago • 10 comments

We now have a Continuous Integration pipeline, as per #122. However, there are some errors that need to be fixed for valid HTML and accessibility:

line 34 column 33 - Warning: missing </button> before <div>
line 35 column 68 - Warning: inserting implicit <button>
line 36 column 33 - Warning: discarding unexpected </button>
line 201 column 53 - Warning: unescaped & or unknown entity "&I"
line 95 column 149 - Warning: <img> lacks "alt" attribute
line 34 column 33 - Warning: trimming empty <button>
line 35 column 68 - Warning: trimming empty <span>
line 35 column 81 - Warning: trimming empty <span>
line 35 column 94 - Warning: trimming empty <span>
line 35 column 107 - Warning: trimming empty <span>
line 35 column 68 - Warning: trimming empty <button>
line 343 column 41 - Warning: <a> proprietary attribute "dnt"
Info: Document content looks like HTML5
Tidy found 12 warnings and 0 errors!

source: https://app.circleci.com/pipelines/github/opensourcediversity/opensourcediversity.org/2/workflows/6ed0dc82-28da-40dc-a6bc-4226f2928d08/jobs/2

jwflory avatar May 20 '21 23:05 jwflory

I can work on this :)

ramyaparimi avatar May 21 '21 02:05 ramyaparimi

Hey @jwflory. Can I work on this?

I have checked your index.html file. So I am pretty sure that I can fix your error for valid HTML.

mayuribotre15 avatar May 21 '21 06:05 mayuribotre15

hey @jwflory can I work on this as , I am the new to opensource.

RR-Sahoo avatar Jun 07 '21 14:06 RR-Sahoo

Hey ! can i work on this?

avnish100 avatar Jun 10 '21 04:06 avnish100

Hey @mayuribotre15 @RR-Sahoo @avnish100 - welcome :) @ramyaparimi are you working on this issue?

jonatoni avatar Jun 10 '21 08:06 jonatoni

is this still available?

avnish100 avatar Jun 15 '21 08:06 avnish100

Hi, is anyone working on this? I am new to open source, I'd love to give it a try

luigi-cardone avatar Aug 05 '21 13:08 luigi-cardone

So, we have to check if someone is working on something first?

op3n-signal avatar Sep 15 '21 21:09 op3n-signal

After looking at markup on index.html, all the errors posted look like they have been resolved?

jasonghent98 avatar Dec 10 '21 16:12 jasonghent98

source: https://app.circleci.com/pipelines/github/opensourcediversity/opensourcediversity.org/2/workflows/6ed0dc82-28da-40dc-a6bc-4226f2928d08/jobs/2

The above source is no more available.

However, I have checked the index,html file, everything seems to be okay

LaideLawal avatar May 20 '22 21:05 LaideLawal

@jwflory seems we can now close this?

sleepypioneer avatar Oct 27 '22 21:10 sleepypioneer

Fixed in #154

Roshanjossey avatar May 15 '23 11:05 Roshanjossey