oso icon indicating copy to clipboard operation
oso copied to clipboard

rotki's first commit is off by more than a year

Open LefterisJP opened this issue 1 year ago • 2 comments

Question: How do you calculate first commit?

rotki's first commit is: https://github.com/rotki/rotki/commit/9c949a200ac34f2190c3bef2d6cdfe095efcb632

That's 9th of May 2017.

According to OSS observer first commit is 15-12-2018. Retrieved from: https://www.opensource.observer/project/rotki

2024-08-03_23-58

LefterisJP avatar Aug 03 '24 21:08 LefterisJP

Interesting ... we use Github archive for historic data. You can also see visualizations from the same dataset here on OSS Insight

image

This shows commits starting in March 2018, but not back to May 2017. But this is also different than what we're showing (December 2018)!

So there are two separate issues:

1. Bug on our end

There's definitely a bug on our end, because our first commit should be the same as OSS Insight / Github archive. I made a change to the underlying model that powers this metric sometime last week, and it must have broke something. Will sort this out!

2. rotki's history

There are a few possible explanations for why your first commit is different than the Github archive record:

  • The pre-2018 commits were made to a repo other than rokti/rotki. Did development begin on some other Github owner or on a repo that's since been deprecated?
  • The pre-2018 commits were made to a private repo that turned public in March 2018.
  • The production branch started out as something like main or master and got renamed to developer in 2018.
  • There's some weird gap in Github archive data from that period.

We have a way of doing backfills to cover gaps in Github archive data, but would like to use that as a last resort since I'm guessing you're not the only one affected by this issue...

ccerv1 avatar Aug 05 '24 19:08 ccerv1

We just ran the following:

gh api -H "Accept: application/vnd.github+json"   -H "X-GitHub-Api-Version: 2022-11-28"   /repos/rotki/rotki

and got back:

 "created_at": "2018-03-05T11:26:09Z"

Actions:

  • [x] Include the created_at (and updated_at) fields in ossd.repositories @ravenac95
  • [x] Update the downstream models to include these new fields as well
  • [ ] Include created_at in the frontend and update copy for first_commit to indicate is the first public commit merged to main

ccerv1 avatar Aug 14 '24 23:08 ccerv1