node-nepali-datetime icon indicating copy to clipboard operation
node-nepali-datetime copied to clipboard

Add support for devanagari date string while parsing

Open aj3sh opened this issue 1 year ago • 2 comments

This feature allows us to take input from Devanagari strings such as "२०७८-०१-१८" into the NepaliDate object. The current parse module should handle the Devanagari string so that the NepaliDate object can be initialized from such class.

const nepaliDate = new NepaliDate("२०७८-०१-१८")

The steps for parsing are like below:

  1. The input (can be both English or Devanagari string)
  2. Translate the Devanagari date strings to English strings. Translation includes numbers, months, and months abbrs.
  3. Use the translated English string for parsing.

aj3sh avatar Feb 01 '24 16:02 aj3sh

In my opinion, we should stick to how native js date initialisation works.

binodnepali avatar Mar 07 '24 15:03 binodnepali

@binodnepali, Thanks for sharing your thoughts. We are adding this feature because we already have a method for formatting in Nepali (.formatNepali), and now we need one for parsing it. Other Nepali date tools are also considering or already have this feature.

If we want to keep initialization simple, we could add a static method like parseNepali(...), which acts as the opposite of formatNepali.

Let's also wait for others' opinions.

aj3sh avatar Mar 09 '24 04:03 aj3sh