Renaming the repository to follow best practices
The best practices recommend to use the bundle logical name as github repository name to avoid collision for people forking them (forking both FOSUserBundle and SonataUserBundle before the renaming would have lead to have only one repo on your account, but a messed one for instance). So the repository should be renamed to OpenSkyLdapBundle (without changing anything in it except the url in the doc). This has been done just now by FOS and Liip, and will be done for FOQ repos soon, and probably other ones as we are asking people to follow the best practice. The sooner it is done the better to avoid changing the repo url after the stable release.
I open the issue here but it applies also for other OpenSky repos.
Thanks. I'll try and get to this within the next few days.
basically, it is just going on the admin panel, writing the new repo name (so writing OpenSky on front of the current one), confirming, and then updating the doc which can be done by non-admin through a PR.
Wouldn't all submodules have to be updated as well? As a repository rename will change the URL, too.
yeah, for projects using it, you have to change the .gitmodules file and then run git submodule sync. But you have to do it for FOS, Liip and FOQ bundles anyway :)
This seems like an awkward hack to work around an issue with GitHub. Shouldn't we take up the fork-with-the-same-name problem with them instead of creating ugly repo URLs?
@bobthecow The same issue goes for other places, like symfony2bundles. We are always referencing bundles using their logical name as this is a good way to know which bundle we talk about (as the logical name should be unique), but a search using it would not find it as the repo uses a shorter name. And this is already used by some bundles (Sensio and WhiteOctober for instance)
*crickets*
:)