opensim-gui icon indicating copy to clipboard operation
opensim-gui copied to clipboard

Adding a negative time range in some Tools is not showing an error

Open AlbertoCasasOrtiz opened this issue 2 years ago • 1 comments

Steps to reproduce

Try to run "Inverse Dynamics...", "Forward Dynamics..." or "Reduce Residuals..." tools with a negative time range (e.g., 2 to 1).

Expected result

A message is shown indicating that the time range cannot be negative (as it happens when trying to execute the "Inverse Kinematics..." tool with a negative time range).

Actual result

Nothing happens.

Environment and GUI version

  • Opensim version: 4.4-2022-05-13-e68ccae and 4.4-2022-05-17-cc0a2cf
  • OS: Windows 10 Pro 64 bits
  • Display: 15.6” 1920x1080

AlbertoCasasOrtiz avatar May 26 '22 12:05 AlbertoCasasOrtiz

There're multiple layers to this:

  1. How does the API handle these situations if input is specified in XML? If it throws then GUI should utilize this functionality to avoid duplication, if not then the API needs a fix.
  2. It would be easy to make the GUI force bounds etc. but I wouldn't go there until the previous item is addressed.
  3. Some of these tools use common base classes so it would be great if we avoid duplication between them.

aymanhab avatar May 31 '22 20:05 aymanhab